motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-09 18:44:58 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

hw/arm/npcm7xx: use qemu_configure_nic_device, allow emc0/emc1 as aliases

Browse source 
Also update the test to specify which device to attach the test socket
to, and remove the comment lamenting the fact that we can't do so.

Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Reviewed-by: Thomas Huth <thuth@redhat.com>
This commit is contained in:
David Woodhouse 2023-10-23 09:37:39 +01:00
parent 27c0235f72
commit 707a42e2db
2 changed files with 13 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

18
tests/qtest/npcm7xx_emc-test.c
View file

@ -225,21 +225,11 @@ static int *packet_test_init(int module_num, GString *cmd_line)
g_assert_cmpint(ret, != , -1);
/*
* KISS and use -nic. We specify two nics (both emc{0,1}) because there's
* currently no way to specify only emc1: The driver implicitly relies on
* emc[i] == nd_table[i].
* KISS and use -nic. The driver accepts 'emc0' and 'emc1' as aliases
* in the 'model' field to specify the device to match.
*/
if (module_num == 0) {
g_string_append_printf(cmd_line,
" -nic socket,fd=%d,model=" TYPE_NPCM7XX_EMC " "
" -nic user,model=" TYPE_NPCM7XX_EMC " ",
test_sockets[1]);
} else {
g_string_append_printf(cmd_line,
" -nic user,model=" TYPE_NPCM7XX_EMC " "
" -nic socket,fd=%d,model=" TYPE_NPCM7XX_EMC " ",
test_sockets[1]);
}
g_string_append_printf(cmd_line, " -nic socket,fd=%d,model=emc%d ",
test_sockets[1], module_num);
g_test_queue_destroy(packet_test_clear, test_sockets);
return test_sockets;