motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-15 06:01:58 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

hw/cxl/mbox: Remove dead code

Browse source 
Two functions were reported to have dead code, remove the bogus
branches altogether, as well as a misplaced qemu_log call.

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Fan Ni <fan.ni@samsung.com>
Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Message-Id: <20240126120132.24248-6-Jonathan.Cameron@huawei.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
Davidlohr Bueso 2024-01-26 12:01:25 +00:00 • committed by Michael S. Tsirkin
parent 64fdad5e67
commit 7031ee540b
1 changed files with 15 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

13
hw/cxl/cxl-mailbox-utils.c
View file

@ -1001,15 +1001,8 @@ static CXLRetCode cmd_sanitize_overwrite(const struct cxl_cmd *cmd,
cxl_dev_disable_media(&ct3d->cxl_dstate); cxl_dev_disable_media(&ct3d->cxl_dstate);
if (secs > 2) {
/* sanitize when done */ /* sanitize when done */
return CXL_MBOX_BG_STARTED; return CXL_MBOX_BG_STARTED;
} else {
__do_sanitization(ct3d);
cxl_dev_enable_media(&ct3d->cxl_dstate);
return CXL_MBOX_SUCCESS;
}
} }
static CXLRetCode cmd_get_security_state(const struct cxl_cmd *cmd, static CXLRetCode cmd_get_security_state(const struct cxl_cmd *cmd,
@ -1387,7 +1380,6 @@ static void bg_timercb(void *opaque)
cci->bg.complete_pct = 100; cci->bg.complete_pct = 100;
cci->bg.ret_code = ret; cci->bg.ret_code = ret;
if (ret == CXL_MBOX_SUCCESS) {
switch (cci->bg.opcode) { switch (cci->bg.opcode) {
case 0x4400: /* sanitize */ case 0x4400: /* sanitize */
{ {
@ -1403,11 +1395,6 @@ static void bg_timercb(void *opaque)
__builtin_unreachable(); __builtin_unreachable();
break; break;
} }
}
qemu_log("Background command %04xh finished: %s\n",
cci->bg.opcode,
ret == CXL_MBOX_SUCCESS ? "success" : "aborted");
} else { } else {
/* estimate only */ /* estimate only */
cci->bg.complete_pct = 100 * now / total_time; cci->bg.complete_pct = 100 * now / total_time;