motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-05 00:33:55 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

tcg/i386: Move tcg_cond_to_jcc[] into tcg_out_cmp

Browse source 
Return the x86 condition codes to use after the compare.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
This commit is contained in:
Richard Henderson 2023-10-23 23:10:13 -07:00
parent c95da56bfe
commit 6749d85bd7
1 changed files with 13 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

24
tcg/i386/tcg-target.c.inc
View file

@ -1449,8 +1449,8 @@ static void tcg_out_jxx(TCGContext *s, int opc, TCGLabel *l, bool small)
} }
} }
static void tcg_out_cmp(TCGContext *s, TCGArg arg1, TCGArg arg2, static int tcg_out_cmp(TCGContext *s, TCGCond cond, TCGArg arg1,
int const_arg2, int rexw) TCGArg arg2, int const_arg2, int rexw)
{ {
if (const_arg2) { if (const_arg2) {
if (arg2 == 0) { if (arg2 == 0) {
@ -1462,14 +1462,15 @@ static void tcg_out_cmp(TCGContext *s, TCGArg arg1, TCGArg arg2,
} else { } else {
tgen_arithr(s, ARITH_CMP + rexw, arg1, arg2); tgen_arithr(s, ARITH_CMP + rexw, arg1, arg2);
} }
return tcg_cond_to_jcc[cond];
} }
static void tcg_out_brcond(TCGContext *s, int rexw, TCGCond cond, static void tcg_out_brcond(TCGContext *s, int rexw, TCGCond cond,
TCGArg arg1, TCGArg arg2, int const_arg2, TCGArg arg1, TCGArg arg2, int const_arg2,
TCGLabel *label, bool small) TCGLabel *label, bool small)
{ {
tcg_out_cmp(s, arg1, arg2, const_arg2, rexw); int jcc = tcg_out_cmp(s, cond, arg1, arg2, const_arg2, rexw);
tcg_out_jxx(s, tcg_cond_to_jcc[cond], label, small); tcg_out_jxx(s, jcc, label, small);
} }
#if TCG_TARGET_REG_BITS == 32 #if TCG_TARGET_REG_BITS == 32
@ -1561,6 +1562,7 @@ static void tcg_out_setcond(TCGContext *s, int rexw, TCGCond cond,
{ {
bool inv = false; bool inv = false;
bool cleared; bool cleared;
int jcc;
switch (cond) { switch (cond) {
case TCG_COND_NE: case TCG_COND_NE:
@ -1597,7 +1599,7 @@ static void tcg_out_setcond(TCGContext *s, int rexw, TCGCond cond,
* We can then use NEG or INC to produce the desired result. * We can then use NEG or INC to produce the desired result.
* This is always smaller than the SETCC expansion. * This is always smaller than the SETCC expansion.
*/ */
tcg_out_cmp(s, arg1, arg2, const_arg2, rexw); tcg_out_cmp(s, TCG_COND_LTU, arg1, arg2, const_arg2, rexw);
/* X - X - C = -C = (C ? -1 : 0) */ /* X - X - C = -C = (C ? -1 : 0) */
tgen_arithr(s, ARITH_SBB + (neg ? rexw : 0), dest, dest); tgen_arithr(s, ARITH_SBB + (neg ? rexw : 0), dest, dest);
@ -1644,8 +1646,8 @@ static void tcg_out_setcond(TCGContext *s, int rexw, TCGCond cond,
cleared = true; cleared = true;
} }
tcg_out_cmp(s, arg1, arg2, const_arg2, rexw); jcc = tcg_out_cmp(s, cond, arg1, arg2, const_arg2, rexw);
tcg_out_modrm(s, OPC_SETCC | tcg_cond_to_jcc[cond], 0, dest); tcg_out_modrm(s, OPC_SETCC | jcc, 0, dest);
if (!cleared) { if (!cleared) {
tcg_out_ext8u(s, dest, dest); tcg_out_ext8u(s, dest, dest);
@ -1716,8 +1718,8 @@ static void tcg_out_movcond(TCGContext *s, int rexw, TCGCond cond,
TCGReg dest, TCGReg c1, TCGArg c2, int const_c2, TCGReg dest, TCGReg c1, TCGArg c2, int const_c2,
TCGReg v1) TCGReg v1)
{ {
tcg_out_cmp(s, c1, c2, const_c2, rexw); int jcc = tcg_out_cmp(s, cond, c1, c2, const_c2, rexw);
tcg_out_cmov(s, tcg_cond_to_jcc[cond], rexw, dest, v1); tcg_out_cmov(s, jcc, rexw, dest, v1);
} }
static void tcg_out_ctz(TCGContext *s, int rexw, TCGReg dest, TCGReg arg1, static void tcg_out_ctz(TCGContext *s, int rexw, TCGReg dest, TCGReg arg1,
@ -1759,8 +1761,8 @@ static void tcg_out_clz(TCGContext *s, int rexw, TCGReg dest, TCGReg arg1,
tgen_arithi(s, ARITH_XOR + rexw, dest, rexw ? 63 : 31, 0); tgen_arithi(s, ARITH_XOR + rexw, dest, rexw ? 63 : 31, 0);
/* Since we have destroyed the flags from BSR, we have to re-test. */ /* Since we have destroyed the flags from BSR, we have to re-test. */
tcg_out_cmp(s, arg1, 0, 1, rexw); int jcc = tcg_out_cmp(s, TCG_COND_EQ, arg1, 0, 1, rexw);
tcg_out_cmov(s, JCC_JE, rexw, dest, arg2); tcg_out_cmov(s, jcc, rexw, dest, arg2);
} }
} }