motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-04 08:13:54 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

qapi: Reject multiple and empty feature descriptions

Browse source 
The parser recognizes only the first "Features:" line.  Any subsequent
ones are treated as ordinary text, as visible in test case
doc-duplicate-features.  Recognize "Features:" lines anywhere.  A
second one is an error.

A 'Features:' line without any features is useless, but not an error.
Make it an error.  This makes detecting a second "Features:" line
easier.

qapi/run-state.json actually has an instance of this since commit
fe17522d85 (qapi: Remove deprecated 'singlestep' member of
StatusInfo).  Clean it up.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20240216145841.2099240-16-armbru@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Markus Armbruster 2024-02-16 15:58:39 +01:00
parent 3d035cd2cc
commit 629c5075aa
6 changed files with 9 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

22
tests/qapi-schema/doc-duplicate-features.out
View file

@ -1,22 +0,0 @@
module ./builtin
object q_empty
enum QType
prefix QTYPE
member none
member qnull
member qnum
member qstring
member qdict
member qlist
member qbool
module doc-duplicate-features.json
command foo None -> None
gen=True success_response=True boxed=False oob=False preconfig=False
feature feat
doc symbol=foo
body=
feature=feat
mumble
section=None
Features: