motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-10 11:04:58 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

hw/acpi/ghes: Make ghes_record_cper_errors() static

Browse source 
acpi_ghes_memory_errors() is the only caller, no need to expose
the function. Besides, the last 'return' in this function isn't
necessary and remove it.

No functional changes intended.

Signed-off-by: Gavin Shan <gshan@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20250214041635.608012-2-gshan@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
This commit is contained in:
Gavin Shan 2025-02-14 14:16:32 +10:00 • committed by Philippe Mathieu-Daudé
parent 00ad70b7fb
commit 611f3bdb20
2 changed files with 2 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
hw/acpi/ghes.c
View file

@ -390,8 +390,8 @@ static void get_hw_error_offsets(uint64_t ghes_addr,
*read_ack_register_addr = ghes_addr + sizeof(uint64_t); *read_ack_register_addr = ghes_addr + sizeof(uint64_t);
} }
void ghes_record_cper_errors(const void *cper, size_t len, static void ghes_record_cper_errors(const void *cper, size_t len,
uint16_t source_id, Error **errp) uint16_t source_id, Error **errp)
{ {
uint64_t cper_addr = 0, read_ack_register_addr = 0, read_ack_register; uint64_t cper_addr = 0, read_ack_register_addr = 0, read_ack_register;
AcpiGedState *acpi_ged_state; AcpiGedState *acpi_ged_state;
@ -440,8 +440,6 @@ void ghes_record_cper_errors(const void *cper, size_t len,
/* Write the generic error data entry into guest memory */ /* Write the generic error data entry into guest memory */
cpu_physical_memory_write(cper_addr, cper, len); cpu_physical_memory_write(cper_addr, cper, len);
return;
} }
int acpi_ghes_memory_errors(uint16_t source_id, uint64_t physical_address) int acpi_ghes_memory_errors(uint16_t source_id, uint64_t physical_address)

2
include/hw/acpi/ghes.h
View file

@ -75,8 +75,6 @@ void acpi_build_hest(GArray *table_data, GArray *hardware_errors,
void acpi_ghes_add_fw_cfg(AcpiGhesState *vms, FWCfgState *s, void acpi_ghes_add_fw_cfg(AcpiGhesState *vms, FWCfgState *s,
GArray *hardware_errors); GArray *hardware_errors);
int acpi_ghes_memory_errors(uint16_t source_id, uint64_t error_physical_addr); int acpi_ghes_memory_errors(uint16_t source_id, uint64_t error_physical_addr);
void ghes_record_cper_errors(const void *cper, size_t len,
uint16_t source_id, Error **errp);
/** /**
* acpi_ghes_present: Report whether ACPI GHES table is present * acpi_ghes_present: Report whether ACPI GHES table is present