motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-07-28 21:03:54 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

qapi: Remove wildcard includes

Browse source 
Wildcard includes become hard to manage when refactoring and dealing
with circular dependencies with strictly typed mypy.

flake8 also flags each one as a warning, as it is not smart enough to
know which names exist in the imported file.

Remove them and include things explicitly by name instead.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20201009161558.107041-7-jsnow@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
This commit is contained in:
John Snow 2020-10-09 12:15:28 -04:00 • committed by Markus Armbruster
parent 7137a96099
commit 5af8263d40
6 changed files with 38 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
scripts/qapi/commands.py
View file

@ -13,7 +13,7 @@ This work is licensed under the terms of the GNU GPL, version 2.
See the COPYING file in the top-level directory. See the COPYING file in the top-level directory.
""" """
from .common import * from .common import build_params, c_name, mcgen
from .gen import QAPIGenCCode, QAPISchemaModularCVisitor, ifcontext from .gen import QAPIGenCCode, QAPISchemaModularCVisitor, ifcontext

7
scripts/qapi/events.py
View file

@ -12,7 +12,12 @@ This work is licensed under the terms of the GNU GPL, version 2.
See the COPYING file in the top-level directory. See the COPYING file in the top-level directory.
""" """
from .common import * from .common import (
build_params,
c_enum_const,
c_name,
mcgen,
)
from .gen import QAPISchemaModularCVisitor, ifcontext from .gen import QAPISchemaModularCVisitor, ifcontext
from .schema import QAPISchemaEnumMember from .schema import QAPISchemaEnumMember
from .types import gen_enum, gen_enum_lookup from .types import gen_enum, gen_enum_lookup

12
scripts/qapi/gen.py
View file

@ -11,13 +11,19 @@
# This work is licensed under the terms of the GNU GPL, version 2. # This work is licensed under the terms of the GNU GPL, version 2.
# See the COPYING file in the top-level directory. # See the COPYING file in the top-level directory.
from contextlib import contextmanager
import errno import errno
import os import os
import re import re
from contextlib import contextmanager
from .common import * from .common import (
c_fname,
gen_endif,
gen_if,
guardend,
guardstart,
mcgen,
)
from .schema import QAPISchemaVisitor from .schema import QAPISchemaVisitor

7
scripts/qapi/introspect.py
View file

@ -10,7 +10,12 @@ This work is licensed under the terms of the GNU GPL, version 2.
See the COPYING file in the top-level directory. See the COPYING file in the top-level directory.
""" """
from .common import * from .common import (
c_name,
gen_endif,
gen_if,
mcgen,
)
from .gen import QAPISchemaMonolithicCVisitor from .gen import QAPISchemaMonolithicCVisitor
from .schema import (QAPISchemaArrayType, QAPISchemaBuiltinType, from .schema import (QAPISchemaArrayType, QAPISchemaBuiltinType,
QAPISchemaType) QAPISchemaType)

8
scripts/qapi/types.py
View file

@ -13,7 +13,13 @@ This work is licensed under the terms of the GNU GPL, version 2.
# See the COPYING file in the top-level directory. # See the COPYING file in the top-level directory.
""" """
from .common import * from .common import (
c_enum_const,
c_name,
gen_endif,
gen_if,
mcgen,
)
from .gen import QAPISchemaModularCVisitor, ifcontext from .gen import QAPISchemaModularCVisitor, ifcontext
from .schema import QAPISchemaEnumMember, QAPISchemaObjectType from .schema import QAPISchemaEnumMember, QAPISchemaObjectType

10
scripts/qapi/visit.py
View file

@ -13,7 +13,15 @@ This work is licensed under the terms of the GNU GPL, version 2.
See the COPYING file in the top-level directory. See the COPYING file in the top-level directory.
""" """
from .common import * from .common import (
c_enum_const,
c_name,
gen_endif,
gen_if,
mcgen,
pop_indent,
push_indent,
)
from .gen import QAPISchemaModularCVisitor, ifcontext from .gen import QAPISchemaModularCVisitor, ifcontext
from .schema import QAPISchemaObjectType from .schema import QAPISchemaObjectType