motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-06 17:23:56 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

replace error_setg(&error_fatal, ...) with error_report()

Browse source 
According to include/qapi/error.h:
* Please don't error_setg(&error_fatal, ...), use error_report() and
* exit(), because that's more obvious.

Patch updates all instances of error_setg(&error_fatal, ...) with
error_report(...), adds the explicit exit(1) and removes redundant
return statements.

Signed-off-by: Tudor Gheorghiu <tudor.reda@gmail.com>
Suggested-by: Thomas Huth <thuth@redhat.com>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2587
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
(Mjt: also fold __func__ to previous line)
This commit is contained in:
Tudor Gheorghiu 2024-10-08 01:27:56 +03:00 • committed by Michael Tokarev
parent f8d3116fdd
commit 5ae3ec6363
6 changed files with 13 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

3
system/vl.c
View file

@ -1841,7 +1841,8 @@ static void object_option_parse(const char *str)
type = qemu_opt_get(opts, "qom-type");
if (!type) {
error_setg(&error_fatal, QERR_MISSING_PARAMETER, "qom-type");
error_report(QERR_MISSING_PARAMETER, "qom-type");
exit(1);
}
if (user_creatable_print_help(type, opts)) {
exit(0);