motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-15 14:13:31 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

usb/dev-mtp: Fix Error double free after inotify failure

Browse source 
error_report_err() frees its first argument.  Freeing it again is
wrong.  Don't.

Fixes: 47287c27d0
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Daniel P. Berrangé <berrange@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200630090351.1247703-7-armbru@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Markus Armbruster 2020-06-30 11:03:31 +02:00
parent 7b8eb7f848
commit 562a558647
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
hw/usb/dev-mtp.c
View file

@ -634,7 +634,6 @@ static void usb_mtp_object_readdir(MTPState *s, MTPObject *o)
error_reportf_err(err, error_reportf_err(err,
"usb-mtp: failed to add watch for %s: ", "usb-mtp: failed to add watch for %s: ",
o->path); o->path);
error_free(err);
} else { } else {
trace_usb_mtp_file_monitor_event(s->dev.addr, o->path, trace_usb_mtp_file_monitor_event(s->dev.addr, o->path,
"Watch Added"); "Watch Added");
@ -1279,7 +1278,6 @@ static void usb_mtp_command(MTPState *s, MTPControl *c)
if (err) { if (err) {
error_reportf_err(err, error_reportf_err(err,
"usb-mtp: file monitoring init failed: "); "usb-mtp: file monitoring init failed: ");
error_free(err);
} else { } else {
QTAILQ_INIT(&s->events); QTAILQ_INIT(&s->events);
} }