mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-08-02 15:23:53 -06:00
qapi: Use QAPI_LIST_PREPEND() where possible
Anywhere we create a list of just one item or by prepending items (typically because order doesn't matter), we can use QAPI_LIST_PREPEND(). But places where we must keep the list in order by appending remain open-coded until later patches. Note that as a side effect, this also performs a cleanup of two minor issues in qga/commands-posix.c: the old code was performing new = g_malloc0(sizeof(*ret)); which 1) is confusing because you have to verify whether 'new' and 'ret' are variables with the same type, and 2) would conflict with C++ compilation (not an actual problem for this file, but makes copy-and-paste harder). Signed-off-by: Eric Blake <eblake@redhat.com> Message-Id: <20201113011340.463563-5-eblake@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> Acked-by: Stefan Hajnoczi <stefanha@redhat.com> [Straightforward conflicts due to commita8aa94b5f8
"qga: update schema for guest-get-disks 'dependents' field" and commita10b453a52
"target/mips: Move mips_cpu_add_definition() from helper.c to cpu.c" resolved. Commit message tweaked.] Signed-off-by: Markus Armbruster <armbru@redhat.com>
This commit is contained in:
parent
eaedde5255
commit
54aa3de72e
32 changed files with 158 additions and 421 deletions
16
ui/input.c
16
ui/input.c
|
@ -571,7 +571,7 @@ void qemu_remove_mouse_mode_change_notifier(Notifier *notify)
|
|||
MouseInfoList *qmp_query_mice(Error **errp)
|
||||
{
|
||||
MouseInfoList *mice_list = NULL;
|
||||
MouseInfoList *info;
|
||||
MouseInfo *info;
|
||||
QemuInputHandlerState *s;
|
||||
bool current = true;
|
||||
|
||||
|
@ -581,16 +581,14 @@ MouseInfoList *qmp_query_mice(Error **errp)
|
|||
continue;
|
||||
}
|
||||
|
||||
info = g_new0(MouseInfoList, 1);
|
||||
info->value = g_new0(MouseInfo, 1);
|
||||
info->value->index = s->id;
|
||||
info->value->name = g_strdup(s->handler->name);
|
||||
info->value->absolute = s->handler->mask & INPUT_EVENT_MASK_ABS;
|
||||
info->value->current = current;
|
||||
info = g_new0(MouseInfo, 1);
|
||||
info->index = s->id;
|
||||
info->name = g_strdup(s->handler->name);
|
||||
info->absolute = s->handler->mask & INPUT_EVENT_MASK_ABS;
|
||||
info->current = current;
|
||||
|
||||
current = false;
|
||||
info->next = mice_list;
|
||||
mice_list = info;
|
||||
QAPI_LIST_PREPEND(mice_list, info);
|
||||
}
|
||||
|
||||
return mice_list;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue