motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-21 09:02:00 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

test-aio-multithread: do not use mb_read/mb_set for simple flags

Browse source 
The remaining use of mb_read/mb_set is just to force a thread to exit
eventually.  It does not order two memory accesses and therefore can be
just read/set.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Paolo Bonzini 2023-03-03 11:57:06 +01:00
parent 6e288b00ef
commit 4f7335e21d
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
tests/unit/test-aio-multithread.c
View file

@ -202,7 +202,7 @@ static CoMutex comutex;
static void coroutine_fn test_multi_co_mutex_entry(void *opaque) static void coroutine_fn test_multi_co_mutex_entry(void *opaque)
{ {
while (!qatomic_mb_read(&now_stopping)) { while (!qatomic_read(&now_stopping)) {
qemu_co_mutex_lock(&comutex); qemu_co_mutex_lock(&comutex);
counter++; counter++;
qemu_co_mutex_unlock(&comutex); qemu_co_mutex_unlock(&comutex);
@ -236,7 +236,7 @@ static void test_multi_co_mutex(int threads, int seconds)
g_usleep(seconds * 1000000); g_usleep(seconds * 1000000);
qatomic_mb_set(&now_stopping, true); qatomic_set(&now_stopping, true);
while (running > 0) { while (running > 0) {
g_usleep(100000); g_usleep(100000);
} }
@ -327,7 +327,7 @@ static void mcs_mutex_unlock(void)
static void test_multi_fair_mutex_entry(void *opaque) static void test_multi_fair_mutex_entry(void *opaque)
{ {
while (!qatomic_mb_read(&now_stopping)) { while (!qatomic_read(&now_stopping)) {
mcs_mutex_lock(); mcs_mutex_lock();
counter++; counter++;
mcs_mutex_unlock(); mcs_mutex_unlock();
@ -355,7 +355,7 @@ static void test_multi_fair_mutex(int threads, int seconds)
g_usleep(seconds * 1000000); g_usleep(seconds * 1000000);
qatomic_mb_set(&now_stopping, true); qatomic_set(&now_stopping, true);
while (running > 0) { while (running > 0) {
g_usleep(100000); g_usleep(100000);
} }
@ -383,7 +383,7 @@ static QemuMutex mutex;
static void test_multi_mutex_entry(void *opaque) static void test_multi_mutex_entry(void *opaque)
{ {
while (!qatomic_mb_read(&now_stopping)) { while (!qatomic_read(&now_stopping)) {
qemu_mutex_lock(&mutex); qemu_mutex_lock(&mutex);
counter++; counter++;
qemu_mutex_unlock(&mutex); qemu_mutex_unlock(&mutex);
@ -411,7 +411,7 @@ static void test_multi_mutex(int threads, int seconds)
g_usleep(seconds * 1000000); g_usleep(seconds * 1000000);
qatomic_mb_set(&now_stopping, true); qatomic_set(&now_stopping, true);
while (running > 0) { while (running > 0) {
g_usleep(100000); g_usleep(100000);
} }