motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2026-03-04 09:04:39 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

qapi/expr.py: Check type of union and alternate 'data' member

Browse source 
Prior to this commit, specifying a non-object value here causes the QAPI
parser to crash in expr.py with a stack trace with (likely) an
AttributeError when we attempt to call that value's items() method.

This member needs to be an object (Dict), and not anything else. Add a
check for this with a nicer error message, and formalize that check with
new test cases that exercise that error.

Signed-off-by: John Snow <jsnow@redhat.com>
Message-Id: <20210421182032.3521476-8-jsnow@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
This commit is contained in:
John Snow 2021-04-21 14:20:22 -04:00 • committed by Markus Armbruster
parent 926bb8add7
commit 4918bb7def
8 changed files with 23 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
tests/qapi-schema/union-invalid-data.json Normal file
View file

@ -0,0 +1,6 @@
# the union data type must be an object.
{ 'union': 'TestUnion',
'base': 'int',
'discriminator': 'int',
'data': ['rubbish', 'nonsense']
}