mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-08-07 09:43:56 -06:00
pci: simplify (pci_/pcie_mmcfg_)data_read()
Remove switch on length: we don't care about high bits for value, so just return all ones if no device. And add one assert(). Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Acked-by: Isaku Yamahata <yamahata@valinux.co.jp>
This commit is contained in:
parent
b6243d991a
commit
4677d8ed9d
2 changed files with 11 additions and 37 deletions
|
@ -71,25 +71,15 @@ uint32_t pci_data_read(PCIBus *s, uint32_t addr, int len)
|
|||
uint32_t config_addr = pci_addr_to_config(addr);
|
||||
uint32_t val;
|
||||
|
||||
assert(len == 1 || len == 2 || len == 4);
|
||||
if (!pci_dev) {
|
||||
switch(len) {
|
||||
case 1:
|
||||
val = 0xff;
|
||||
break;
|
||||
case 2:
|
||||
val = 0xffff;
|
||||
break;
|
||||
default:
|
||||
case 4:
|
||||
val = 0xffffffff;
|
||||
break;
|
||||
}
|
||||
} else {
|
||||
val = pci_dev->config_read(pci_dev, config_addr, len);
|
||||
PCI_DPRINTF("%s: %s: addr=%02"PRIx32" val=%08"PRIx32" len=%d\n",
|
||||
__func__, pci_dev->name, config_addr, val, len);
|
||||
return ~0x0;
|
||||
}
|
||||
|
||||
val = pci_dev->config_read(pci_dev, config_addr, len);
|
||||
PCI_DPRINTF("%s: %s: addr=%02"PRIx32" val=%08"PRIx32" len=%d\n",
|
||||
__func__, pci_dev->name, config_addr, val, len);
|
||||
|
||||
return val;
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue