motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-09-09 00:07:57 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

hw/ide/ahci: Convert AHCIState::ports to unsigned

Browse source 
AHCIState::ports should be unsigned. Besides, we never
check it for negative value. It is unlikely it was ever
used with more than INT32_MAX ports, so it is safe to
convert it to unsigned.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20240213081201.78951-7-philmd@linaro.org>
This commit is contained in:
Philippe Mathieu-Daudé 2024-02-13 06:29:00 +01:00
parent e2f8d28005
commit 44c11b2e69
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
hw/ide/ahci.c
View file

@ -1819,7 +1819,7 @@ const VMStateDescription vmstate_ahci = {
.version_id = 1, .version_id = 1,
.post_load = ahci_state_post_load, .post_load = ahci_state_post_load,
.fields = (const VMStateField[]) { .fields = (const VMStateField[]) {
VMSTATE_STRUCT_VARRAY_POINTER_INT32(dev, AHCIState, ports, VMSTATE_STRUCT_VARRAY_POINTER_UINT32(dev, AHCIState, ports,
vmstate_ahci_device, AHCIDevice), vmstate_ahci_device, AHCIDevice),
VMSTATE_UINT32(control_regs.cap, AHCIState), VMSTATE_UINT32(control_regs.cap, AHCIState),
VMSTATE_UINT32(control_regs.ghc, AHCIState), VMSTATE_UINT32(control_regs.ghc, AHCIState),
@ -1827,7 +1827,7 @@ const VMStateDescription vmstate_ahci = {
VMSTATE_UINT32(control_regs.impl, AHCIState), VMSTATE_UINT32(control_regs.impl, AHCIState),
VMSTATE_UINT32(control_regs.version, AHCIState), VMSTATE_UINT32(control_regs.version, AHCIState),
VMSTATE_UINT32(idp_index, AHCIState), VMSTATE_UINT32(idp_index, AHCIState),
VMSTATE_INT32_EQUAL(ports, AHCIState, NULL), VMSTATE_UINT32_EQUAL(ports, AHCIState, NULL),
VMSTATE_END_OF_LIST() VMSTATE_END_OF_LIST()
}, },
}; };

2
include/hw/ide/ahci.h
View file

@ -46,7 +46,7 @@ typedef struct AHCIState {
MemoryRegion idp; /* Index-Data Pair I/O port space */ MemoryRegion idp; /* Index-Data Pair I/O port space */
unsigned idp_offset; /* Offset of index in I/O port space */ unsigned idp_offset; /* Offset of index in I/O port space */
uint32_t idp_index; /* Current IDP index */ uint32_t idp_index; /* Current IDP index */
int32_t ports; uint32_t ports;
qemu_irq irq; qemu_irq irq;
AddressSpace *as; AddressSpace *as;
} AHCIState; } AHCIState;