target/ppc: Use qemu_guest_getrandom for DARN

We now have an interface for guest visible random numbers.

Acked-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
This commit is contained in:
Richard Henderson 2019-03-14 14:46:41 -07:00
parent 7e4357f612
commit 3f74b6322c

View file

@ -23,6 +23,8 @@
#include "exec/helper-proto.h" #include "exec/helper-proto.h"
#include "crypto/aes.h" #include "crypto/aes.h"
#include "fpu/softfloat.h" #include "fpu/softfloat.h"
#include "qapi/error.h"
#include "qemu/guest-random.h"
#include "helper_regs.h" #include "helper_regs.h"
/*****************************************************************************/ /*****************************************************************************/
@ -158,24 +160,37 @@ uint32_t helper_cmpeqb(target_ulong ra, target_ulong rb)
#undef hasvalue #undef hasvalue
/* /*
* Return invalid random number. * Return a random number.
*
* FIXME: Add rng backend or other mechanism to get cryptographically suitable
* random number
*/ */
target_ulong helper_darn32(void) uint64_t helper_darn32(void)
{ {
Error *err = NULL;
uint32_t ret;
if (qemu_guest_getrandom(&ret, sizeof(ret), &err) < 0) {
qemu_log_mask(LOG_UNIMP, "darn: Crypto failure: %s",
error_get_pretty(err));
error_free(err);
return -1; return -1;
} }
target_ulong helper_darn64(void) return ret;
}
uint64_t helper_darn64(void)
{ {
Error *err = NULL;
uint64_t ret;
if (qemu_guest_getrandom(&ret, sizeof(ret), &err) < 0) {
qemu_log_mask(LOG_UNIMP, "darn: Crypto failure: %s",
error_get_pretty(err));
error_free(err);
return -1; return -1;
} }
#endif return ret;
}
#if defined(TARGET_PPC64)
uint64_t helper_bpermd(uint64_t rs, uint64_t rb) uint64_t helper_bpermd(uint64_t rs, uint64_t rb)
{ {