motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-12-11 16:00:50 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix coding style issue

Browse source 
Replace:

  if (-1 == foo())

with:

  if (foo() == -1)

While this coding style is not in direct contravention of our currently
ratified CODING_STYLE treaty, it could be argued that the Article 3 of
the European Convention on Human Rights (prohibiting torture and "inhuman
or degrading treatment") reads on the matter.

[This commit message was brought to you without humour, as is evidenced
by the absence of any emoticons]

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Cc: Avi Kivity <avi@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
This commit is contained in:
Mark McLoughlin 2009-09-23 11:24:05 +01:00 • committed by Blue Swirl
parent 9262f3841b
commit 3df04ac3c6
4 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
qemu-option.c
View file

@ -267,7 +267,7 @@ int set_option_parameter(QEMUOptionParameter *list, const char *name,
// Process parameter
switch (list->type) {
case OPT_FLAG:
if (-1 == parse_option_bool(name, value, &flag))
if (parse_option_bool(name, value, &flag) == -1)
return -1;
list->value.n = flag;
break;
@ -282,7 +282,7 @@ int set_option_parameter(QEMUOptionParameter *list, const char *name,
break;
case OPT_SIZE:
if (-1 == parse_option_size(name, value, &list->value.n))
if (parse_option_size(name, value, &list->value.n) == -1)
return -1;
break;
@ -745,7 +745,7 @@ int qemu_opts_do_parse(QemuOpts *opts, const char *params, const char *firstname
}
if (strcmp(option, "id") != 0) {
/* store and parse */
if (-1 == qemu_opt_set(opts, option, value)) {
if (qemu_opt_set(opts, option, value) == -1) {
return -1;
}
}