motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-22 09:32:40 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

lan9118: switch to use qemu_receive_packet() for loopback

Browse source 
This patch switches to use qemu_receive_packet() which can detect
reentrancy and return early.

This is intended to address CVE-2021-3416.

Cc: Prasad J Pandit <ppandit@redhat.com>
Cc: qemu-stable@nongnu.org
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Signed-off-by: Jason Wang <jasowang@redhat.com>
This commit is contained in:
Alexander Bulekov 2021-03-01 14:35:30 -05:00 • committed by Jason Wang
parent e73adfbeec
commit 37cee01784
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
hw/net/lan9118.c
View file

@ -680,7 +680,7 @@ static void do_tx_packet(lan9118_state *s)
/* FIXME: Honor TX disable, and allow queueing of packets. */ /* FIXME: Honor TX disable, and allow queueing of packets. */
if (s->phy_control & 0x4000) { if (s->phy_control & 0x4000) {
/* This assumes the receive routine doesn't touch the VLANClient. */ /* This assumes the receive routine doesn't touch the VLANClient. */
lan9118_receive(qemu_get_queue(s->nic), s->txp->data, s->txp->len); qemu_receive_packet(qemu_get_queue(s->nic), s->txp->data, s->txp->len);
} else { } else {
qemu_send_packet(qemu_get_queue(s->nic), s->txp->data, s->txp->len); qemu_send_packet(qemu_get_queue(s->nic), s->txp->data, s->txp->len);
} }