motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-07-25 19:33:54 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

9pfs: Introduce futimens file op

Browse source 
Add an futimens operation to the fs driver and use if when a fid has
a valid file descriptor. This is required to support more cases where
the client wants to do an action on an unlinked file which it still
has an open file decriptor for.

Only 9P2000.L was considered.

Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Message-Id: <20250312152933.383967-5-groug@kaod.org>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
This commit is contained in:
Greg Kurz 2025-03-12 16:29:30 +01:00 • committed by Christian Schoenebeck
parent 0c798dd523
commit 371a269ff8
7 changed files with 46 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
fsdev/file-op-9p.h
View file

@ -129,6 +129,8 @@ struct FileOperations {
int (*chown)(FsContext *, V9fsPath *, FsCred *);
int (*mknod)(FsContext *, V9fsPath *, const char *, FsCred *);
int (*utimensat)(FsContext *, V9fsPath *, const struct timespec *);
int (*futimens)(FsContext *ctx, int fid_type, V9fsFidOpenState *fs,
const struct timespec *times);
int (*remove)(FsContext *, const char *);
int (*symlink)(FsContext *, const char *, V9fsPath *,
const char *, FsCred *);

9
hw/9pfs/9p-local.c
View file

@ -1100,6 +1100,14 @@ out:
return ret;
}
static int local_futimens(FsContext *s, int fid_type, V9fsFidOpenState *fs,
const struct timespec *times)
{
int fd = local_fid_fd(fid_type, fs);
return qemu_futimens(fd, times);
}
static int local_unlinkat_common(FsContext *ctx, int dirfd, const char *name,
int flags)
{
@ -1626,4 +1634,5 @@ FileOperations local_ops = {
.unlinkat = local_unlinkat,
.has_valid_file_handle = local_has_valid_file_handle,
.ftruncate = local_ftruncate,
.futimens = local_futimens,
};

8
hw/9pfs/9p-synth.c
View file

@ -424,6 +424,13 @@ static int synth_utimensat(FsContext *fs_ctx, V9fsPath *path,
return 0;
}
static int synth_futimens(FsContext *fs_ctx, int fid_type, V9fsFidOpenState *fs,
const struct timespec *buf)
{
errno = ENOSYS;
return -1;
}
static int synth_remove(FsContext *ctx, const char *path)
{
errno = EPERM;
@ -664,4 +671,5 @@ FileOperations synth_ops = {
.unlinkat = synth_unlinkat,
.has_valid_file_handle = synth_has_valid_file_handle,
.ftruncate = synth_ftruncate,
.futimens = synth_futimens,
};

1
hw/9pfs/9p-util.h
View file

@ -103,6 +103,7 @@ static inline int errno_to_dotl(int err) {
#define qemu_renameat renameat
#define qemu_utimensat utimensat
#define qemu_unlinkat unlinkat
#define qemu_futimens futimens
static inline void close_preserve_errno(int fd)
{

6
hw/9pfs/9p.c
View file

@ -1727,7 +1727,11 @@ static void coroutine_fn v9fs_setattr(void *opaque)
} else {
times[1].tv_nsec = UTIME_OMIT;
}
err = v9fs_co_utimensat(pdu, &fidp->path, times);
if (fid_has_valid_file_handle(pdu->s, fidp)) {
err = v9fs_co_futimens(pdu, fidp, times);
} else {
err = v9fs_co_utimensat(pdu, &fidp->path, times);
}
if (err < 0) {
goto out;
}

19
hw/9pfs/cofs.c
View file

@ -139,6 +139,25 @@ int coroutine_fn v9fs_co_utimensat(V9fsPDU *pdu, V9fsPath *path,
return err;
}
int coroutine_fn v9fs_co_futimens(V9fsPDU *pdu, V9fsFidState *fidp,
struct timespec times[2])
{
int err;
V9fsState *s = pdu->s;
if (v9fs_request_cancelled(pdu)) {
return -EINTR;
}
v9fs_co_run_in_worker(
{
err = s->ops->futimens(&s->ctx, fidp->fid_type, &fidp->fs, times);
if (err < 0) {
err = -errno;
}
});
return err;
}
int coroutine_fn v9fs_co_chown(V9fsPDU *pdu, V9fsPath *path, uid_t uid,
gid_t gid)
{

2
hw/9pfs/coth.h
View file

@ -71,6 +71,8 @@ int coroutine_fn v9fs_co_statfs(V9fsPDU *, V9fsPath *, struct statfs *);
int coroutine_fn v9fs_co_lstat(V9fsPDU *, V9fsPath *, struct stat *);
int coroutine_fn v9fs_co_chmod(V9fsPDU *, V9fsPath *, mode_t);
int coroutine_fn v9fs_co_utimensat(V9fsPDU *, V9fsPath *, struct timespec [2]);
int coroutine_fn v9fs_co_futimens(V9fsPDU *pdu, V9fsFidState *fidp,
struct timespec times[2]);
int coroutine_fn v9fs_co_chown(V9fsPDU *, V9fsPath *, uid_t, gid_t);
int coroutine_fn v9fs_co_truncate(V9fsPDU *, V9fsPath *, off_t);
int coroutine_fn v9fs_co_ftruncate(V9fsPDU *pdu, V9fsFidState *fidp,