motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-04 16:23:55 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

nvme: remove constant argument to tracepoint

Browse source 
The last argument to -pci_nvme_err_startfail_virt_state is always "OFFLINE"
due to the enclosing "if" condition requiring !sctrl->scs.  Reported by
Coverity.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Paolo Bonzini 2023-03-30 14:14:31 +02:00
parent 0abe33c13a
commit 3488fc3262
2 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
hw/nvme/ctrl.c
View file

@ -7158,9 +7158,7 @@ static int nvme_start_ctrl(NvmeCtrl *n)
if (pci_is_vf(PCI_DEVICE(n)) && !sctrl->scs) {
trace_pci_nvme_err_startfail_virt_state(le16_to_cpu(sctrl->nvi),
le16_to_cpu(sctrl->nvq),
sctrl->scs ? "ONLINE" :
"OFFLINE");
le16_to_cpu(sctrl->nvq));
return -1;
}
if (unlikely(n->cq[0])) {