motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-07-28 04:43:54 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

contrib/plugins/cache.c: Remove redundant check of l2_access

Browse source 
In append_stats_line(), we have an expression
   l2_access ? l2_miss_rate : 0.0
But this is inside an if (l2_access && l2_misses) { ... } block,
so Coverity points out that the false part of the ?: is dead code.

Remove the unnecessary test.

Resolves: Coverity CID 1522458
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20240725164851.1930964-1-peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240729144414.830369-12-alex.bennee@linaro.org>
This commit is contained in:
Peter Maydell 2024-07-29 15:44:11 +01:00 • committed by Alex Bennée
parent 6484a3e55b
commit 33ef9cdc28
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
contrib/plugins/cache.c
View file

@ -558,7 +558,7 @@ static void append_stats_line(GString *line,
" %-12" PRIu64 " %-11" PRIu64 " %10.4lf%%", " %-12" PRIu64 " %-11" PRIu64 " %10.4lf%%",
l2_access, l2_access,
l2_misses, l2_misses,
l2_access ? l2_miss_rate : 0.0); l2_miss_rate);
} }
g_string_append(line, "\n"); g_string_append(line, "\n");