motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-12-11 16:00:50 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

migration: Fix incorrect integer->float conversion caught by clang

Browse source 
Clang does not like qmp_migrate_set_downtime()'s code to clamp double
@value to 0..INT64_MAX:

    qemu/migration/migration.c:2038:24: error: implicit conversion from 'long' to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Werror,-Wimplicit-int-float-conversion]

The warning will be enabled by default in clang 10. It is not
available for clang <= 9.

The clamp is actually useless; @value is checked to be within
0..MAX_MIGRATE_DOWNTIME_SECONDS immediately before.  Delete it.

While there, make the conversion from double to int64_t explicit.

Signed-off-by: Fangrui Song <i@maskray.me>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
[Patch split, commit message improved]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
This commit is contained in:
Fangrui Song 2019-11-22 09:00:38 +01:00 • committed by Juan Quintela
parent 97e1e06780
commit 2667c98722
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
migration/migration.c
View file

@ -2035,11 +2035,10 @@ void qmp_migrate_set_downtime(double value, Error **errp)
} }
value *= 1000; /* Convert to milliseconds */ value *= 1000; /* Convert to milliseconds */
value = MAX(0, MIN(INT64_MAX, value));
MigrateSetParameters p = { MigrateSetParameters p = {
.has_downtime_limit = true, .has_downtime_limit = true,
.downtime_limit = value, .downtime_limit = (int64_t)value,
}; };
qmp_migrate_set_parameters(&p, errp); qmp_migrate_set_parameters(&p, errp);