motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-12-11 16:00:50 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

qtest: Don't segfault with invalid -qtest option

Browse source 
This prints an error message, instead of core dump, when "-qtest"
option value is invalid, e.g.:

    $ ./x86_64-softmmu/qemu-system-x86_64 -qtest unknown
        qemu-system-x86_64: Failed to initialize device for qtest:
        "unknown"

Signed-off-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
This commit is contained in:
Fam Zheng 2014-02-10 09:28:02 +08:00 • committed by Andreas Färber
parent 1f9c4cfda4
commit 23802b4fe0
3 changed files with 16 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
qtest.c
View file

@ -507,12 +507,18 @@ int qtest_init_accel(void)
return 0;
}
void qtest_init(const char *qtest_chrdev, const char *qtest_log)
void qtest_init(const char *qtest_chrdev, const char *qtest_log, Error **errp)
{
CharDriverState *chr;
chr = qemu_chr_new("qtest", qtest_chrdev, NULL);
if (chr == NULL) {
error_setg(errp, "Failed to initialize device for qtest: \"%s\"",
qtest_chrdev);
return;
}
qemu_chr_add_handlers(chr, qtest_can_read, qtest_read, qtest_event, chr);
qemu_chr_fe_set_echo(chr, true);