motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-22 09:32:40 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

hw/arm: xlnx-zynqmp: Clean up coding convention issues

Browse source 
There are some coding convention warnings in xlnx-zynqmp.c and
xlnx-zynqmp.h, as reported by:

  $ ./scripts/checkpatch.pl include/hw/arm/xlnx-zynqmp.h
  $ ./scripts/checkpatch.pl hw/arm/xlnx-zynqmp.c

Let's clean them up.

Signed-off-by: Xuzhou Cheng <xuzhou.cheng@windriver.com>
Signed-off-by: Bin Meng <bin.meng@windriver.com>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Message-id: 20210303135254.3970-3-bmeng.cn@gmail.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
This commit is contained in:
Xuzhou Cheng 2021-03-03 21:52:51 +08:00 • committed by Peter Maydell
parent 35593573b2
commit 21bce3717e
2 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
hw/arm/xlnx-zynqmp.c
View file

@ -301,11 +301,13 @@ static void xlnx_zynqmp_realize(DeviceState *dev, Error **errp)
ram_size = memory_region_size(s->ddr_ram); ram_size = memory_region_size(s->ddr_ram);
/* Create the DDR Memory Regions. User friendly checks should happen at /*
* Create the DDR Memory Regions. User friendly checks should happen at
* the board level * the board level
*/ */
if (ram_size > XLNX_ZYNQMP_MAX_LOW_RAM_SIZE) { if (ram_size > XLNX_ZYNQMP_MAX_LOW_RAM_SIZE) {
/* The RAM size is above the maximum available for the low DDR. /*
* The RAM size is above the maximum available for the low DDR.
* Create the high DDR memory region as well. * Create the high DDR memory region as well.
*/ */
assert(ram_size <= XLNX_ZYNQMP_MAX_RAM_SIZE); assert(ram_size <= XLNX_ZYNQMP_MAX_RAM_SIZE);
@ -521,7 +523,8 @@ static void xlnx_zynqmp_realize(DeviceState *dev, Error **errp)
SysBusDevice *sbd = SYS_BUS_DEVICE(&s->sdhci[i]); SysBusDevice *sbd = SYS_BUS_DEVICE(&s->sdhci[i]);
Object *sdhci = OBJECT(&s->sdhci[i]); Object *sdhci = OBJECT(&s->sdhci[i]);
/* Compatible with: /*
* Compatible with:
* - SD Host Controller Specification Version 3.00 * - SD Host Controller Specification Version 3.00
* - SDIO Specification Version 3.0 * - SDIO Specification Version 3.0
* - eMMC Specification Version 4.51 * - eMMC Specification Version 4.51

3
include/hw/arm/xlnx-zynqmp.h
View file

@ -60,7 +60,8 @@ OBJECT_DECLARE_SIMPLE_TYPE(XlnxZynqMPState, XLNX_ZYNQMP)
#define XLNX_ZYNQMP_GIC_REGIONS 6 #define XLNX_ZYNQMP_GIC_REGIONS 6
/* ZynqMP maps the ARM GIC regions (GICC, GICD ...) at consecutive 64k offsets /*
* ZynqMP maps the ARM GIC regions (GICC, GICD ...) at consecutive 64k offsets
* and under-decodes the 64k region. This mirrors the 4k regions to every 4k * and under-decodes the 64k region. This mirrors the 4k regions to every 4k
* aligned address in the 64k region. To implement each GIC region needs a * aligned address in the 64k region. To implement each GIC region needs a
* number of memory region aliases. * number of memory region aliases.