motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-10 19:14:58 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

hw/pcmcia/pxa2xx: Realize sysbus device before accessing it

Browse source 
sysbus_mmio_map() should not be called on unrealized device.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20231020130331.50048-4-philmd@linaro.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
This commit is contained in:
Philippe Mathieu-Daudé 2023-10-20 15:03:24 +02:00 • committed by Peter Maydell
parent d8239c475b
commit 217ceefee0
1 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
hw/pcmcia/pxa2xx.c
View file

@ -142,15 +142,12 @@ PXA2xxPCMCIAState *pxa2xx_pcmcia_init(MemoryRegion *sysmem,
hwaddr base) hwaddr base)
{ {
DeviceState *dev; DeviceState *dev;
PXA2xxPCMCIAState *s;
dev = qdev_new(TYPE_PXA2XX_PCMCIA); dev = qdev_new(TYPE_PXA2XX_PCMCIA);
sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, base);
s = PXA2XX_PCMCIA(dev);
sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal); sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal);
sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, base);
return s; return PXA2XX_PCMCIA(dev);
} }
static void pxa2xx_pcmcia_initfn(Object *obj) static void pxa2xx_pcmcia_initfn(Object *obj)