motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-04 00:03:54 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

python/qemu: Adjust traceback typing

Browse source 
mypy considers it incorrect to use `bool` to statically return false,
because it will assume that it could conceivably return True, and gives
different analysis in that case. Use a None return to achieve the same
effect, but make mypy happy.

Note: Pylint considers function signatures as code that might trip the
duplicate-code checker. I'd rather not disable this as it does not
trigger often in practice, so I'm disabling it as a one-off and filed a
change request; see https://github.com/PyCQA/pylint/issues/3619

Signed-off-by: John Snow <jsnow@redhat.com>
Acked-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200514055403.18902-14-jsnow@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
This commit is contained in:
John Snow 2020-05-14 01:53:44 -04:00 • committed by Philippe Mathieu-Daudé
parent 0add048fbd
commit 1dda0404d8
2 changed files with 14 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
python/qemu/machine.py
View file

@ -24,6 +24,8 @@ import subprocess
import shutil
import socket
import tempfile
from typing import Optional, Type
from types import TracebackType
from . import qmp
@ -124,9 +126,11 @@ class QEMUMachine:
def __enter__(self):
return self
def __exit__(self, exc_type, exc_val, exc_tb):
def __exit__(self,
exc_type: Optional[Type[BaseException]],
exc_val: Optional[BaseException],
exc_tb: Optional[TracebackType]) -> None:
self.shutdown()
return False
def add_monitor_null(self):
"""