motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-03 07:43:54 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

job: Move defer_to_main_loop to Job

Browse source 
Move the defer_to_main_loop functionality from BlockJob to Job.

The code can be simplified because we can use job->aio_context in
job_defer_to_main_loop_bh() now, instead of having to access the
BlockDriverState.

Probably taking the data->aio_context lock in addition was already
unnecessary in the old code because we didn't actually make use of
anything protected by the old AioContext except getting the new
AioContext, in case it changed between scheduling the BH and running it.
But it's certainly unnecessary now that the BDS isn't accessed at all
any more.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
This commit is contained in:
Kevin Wolf 2018-04-17 16:41:17 +02:00
parent 08be6fe26f
commit 1908a5590c
12 changed files with 97 additions and 110 deletions
Download patch file Download diff file Expand all files Collapse all files

7
tests/test-bdrv-drain.c
View file

@ -496,9 +496,10 @@ typedef struct TestBlockJob {
bool should_complete;
} TestBlockJob;
static void test_job_completed(BlockJob *job, void *opaque)
static void test_job_completed(Job *job, void *opaque)
{
block_job_completed(job, 0);
BlockJob *bjob = container_of(job, BlockJob, job);
block_job_completed(bjob, 0);
}
static void coroutine_fn test_job_start(void *opaque)
@ -510,7 +511,7 @@ static void coroutine_fn test_job_start(void *opaque)
block_job_sleep_ns(&s->common, 100000);
}
block_job_defer_to_main_loop(&s->common, test_job_completed, NULL);
job_defer_to_main_loop(&s->common.job, test_job_completed, NULL);
}
static void test_job_complete(BlockJob *job, Error **errp)

13
tests/test-blockjob-txn.c
View file

@ -24,16 +24,17 @@ typedef struct {
int *result;
} TestBlockJob;
static void test_block_job_complete(BlockJob *job, void *opaque)
static void test_block_job_complete(Job *job, void *opaque)
{
BlockDriverState *bs = blk_bs(job->blk);
BlockJob *bjob = container_of(job, BlockJob, job);
BlockDriverState *bs = blk_bs(bjob->blk);
int rc = (intptr_t)opaque;
if (job_is_cancelled(&job->job)) {
if (job_is_cancelled(job)) {
rc = -ECANCELED;
}
block_job_completed(job, rc);
block_job_completed(bjob, rc);
bdrv_unref(bs);
}
@ -54,8 +55,8 @@ static void coroutine_fn test_block_job_run(void *opaque)
}
}
block_job_defer_to_main_loop(job, test_block_job_complete,
(void *)(intptr_t)s->rc);
job_defer_to_main_loop(&job->job, test_block_job_complete,
(void *)(intptr_t)s->rc);
}
typedef struct {

7
tests/test-blockjob.c
View file

@ -161,11 +161,12 @@ typedef struct CancelJob {
bool completed;
} CancelJob;
static void cancel_job_completed(BlockJob *job, void *opaque)
static void cancel_job_completed(Job *job, void *opaque)
{
BlockJob *bjob = container_of(job, BlockJob, job);
CancelJob *s = opaque;
s->completed = true;
block_job_completed(job, 0);
block_job_completed(bjob, 0);
}
static void cancel_job_complete(BlockJob *job, Error **errp)
@ -191,7 +192,7 @@ static void coroutine_fn cancel_job_start(void *opaque)
}
defer:
block_job_defer_to_main_loop(&s->common, cancel_job_completed, s);
job_defer_to_main_loop(&s->common.job, cancel_job_completed, s);
}
static const BlockJobDriver test_cancel_driver = {