mirror of
https://github.com/Motorhead1991/qemu.git
synced 2025-08-05 16:53:55 -06:00
Hexagon (target/hexagon) Additional instructions handled by idef-parser
**** Changes in v3 ****
Fix bugs exposed by dpmpyss_rnd_s0 instruction
Set correct size/signedness for constants
Test cases added to tests/tcg/hexagon/misc.c
**** Changes in v2 ****
Fix bug in imm_print identified in clang build
Currently, idef-parser skips all floating point instructions. However,
there are some floating point instructions that can be handled.
The following instructions are now parsed
F2_sfimm_p
F2_sfimm_n
F2_dfimm_p
F2_dfimm_n
F2_dfmpyll
F2_dfmpylh
To make these instructions work, we fix some bugs in parser-helpers.c
gen_rvalue_extend
gen_cast_op
imm_print
lexer properly sets size/signedness of constants
Test cases added to tests/tcg/hexagon/fpstuff.c
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Tested-by: Anton Johansson <anjo@rev.ng>
Reviewed-by: Anton Johansson <anjo@rev.ng>
Message-Id: <20230501203125.4025991-1-tsimpson@quicinc.com>
This commit is contained in:
Taylor Simpson
parent
0fc56c4375
commit
163e5fa38e
7 changed files with 160 additions and 41 deletions
|
|
@ -103,7 +103,15 @@ def main():
|
|||
continue
|
||||
if tag.startswith("V6_"):
|
||||
continue
|
||||
if tag.startswith("F"):
|
||||
if ( tag.startswith("F") and
|
||||
tag not in {
|
||||
"F2_sfimm_p",
|
||||
"F2_sfimm_n",
|
||||
"F2_dfimm_p",
|
||||
"F2_dfimm_n",
|
||||
"F2_dfmpyll",
|
||||
"F2_dfmpylh"
|
||||
}):
|
||||
continue
|
||||
if tag.endswith("_locked"):
|
||||
continue
|
||||
|
|
|
|||
|
|
@ -401,12 +401,39 @@ STRING_LIT \"(\\.|[^"\\])*\"
|
|||
}
|
||||
return SIGN;
|
||||
}
|
||||
"0x"{HEX_DIGIT}+ |
|
||||
{DIGIT}+ { yylval->rvalue.type = IMMEDIATE;
|
||||
yylval->rvalue.bit_width = 32;
|
||||
yylval->rvalue.signedness = SIGNED;
|
||||
"0x"{HEX_DIGIT}+ { uint64_t value = strtoull(yytext, NULL, 0);
|
||||
yylval->rvalue.type = IMMEDIATE;
|
||||
yylval->rvalue.imm.type = VALUE;
|
||||
yylval->rvalue.imm.value = strtoull(yytext, NULL, 0);
|
||||
yylval->rvalue.imm.value = value;
|
||||
if (value <= INT_MAX) {
|
||||
yylval->rvalue.bit_width = sizeof(int) * 8;
|
||||
yylval->rvalue.signedness = SIGNED;
|
||||
} else if (value <= UINT_MAX) {
|
||||
yylval->rvalue.bit_width = sizeof(unsigned int) * 8;
|
||||
yylval->rvalue.signedness = UNSIGNED;
|
||||
} else if (value <= LONG_MAX) {
|
||||
yylval->rvalue.bit_width = sizeof(long) * 8;
|
||||
yylval->rvalue.signedness = SIGNED;
|
||||
} else if (value <= ULONG_MAX) {
|
||||
yylval->rvalue.bit_width = sizeof(unsigned long) * 8;
|
||||
yylval->rvalue.signedness = UNSIGNED;
|
||||
} else {
|
||||
g_assert_not_reached();
|
||||
}
|
||||
return IMM; }
|
||||
{DIGIT}+ { int64_t value = strtoll(yytext, NULL, 0);
|
||||
yylval->rvalue.type = IMMEDIATE;
|
||||
yylval->rvalue.imm.type = VALUE;
|
||||
yylval->rvalue.imm.value = value;
|
||||
if (value >= INT_MIN && value <= INT_MAX) {
|
||||
yylval->rvalue.bit_width = sizeof(int) * 8;
|
||||
yylval->rvalue.signedness = SIGNED;
|
||||
} else if (value >= LONG_MIN && value <= LONG_MAX) {
|
||||
yylval->rvalue.bit_width = sizeof(long) * 8;
|
||||
yylval->rvalue.signedness = SIGNED;
|
||||
} else {
|
||||
g_assert_not_reached();
|
||||
}
|
||||
return IMM; }
|
||||
"0x"{HEX_DIGIT}+"ULL" |
|
||||
{DIGIT}+"ULL" { yylval->rvalue.type = IMMEDIATE;
|
||||
|
|
|
|||
|
|
@ -594,8 +594,6 @@ rvalue : FAIL
|
|||
| CAST rvalue
|
||||
{
|
||||
@1.last_column = @2.last_column;
|
||||
/* Assign target signedness */
|
||||
$2.signedness = $1.signedness;
|
||||
$$ = gen_cast_op(c, &@1, &$2, $1.bit_width, $1.signedness);
|
||||
}
|
||||
| rvalue EQ rvalue
|
||||
|
|
|
|||
|
|
@ -167,8 +167,9 @@ void reg_print(Context *c, YYLTYPE *locp, HexReg *reg)
|
|||
EMIT(c, "hex_gpr[%u]", reg->id);
|
||||
}
|
||||
|
||||
void imm_print(Context *c, YYLTYPE *locp, HexImm *imm)
|
||||
void imm_print(Context *c, YYLTYPE *locp, HexValue *rvalue)
|
||||
{
|
||||
HexImm *imm = &rvalue->imm;
|
||||
switch (imm->type) {
|
||||
case I:
|
||||
EMIT(c, "i");
|
||||
|
|
@ -177,7 +178,21 @@ void imm_print(Context *c, YYLTYPE *locp, HexImm *imm)
|
|||
EMIT(c, "%ciV", imm->id);
|
||||
break;
|
||||
case VALUE:
|
||||
EMIT(c, "((int64_t) %" PRIu64 "ULL)", (int64_t) imm->value);
|
||||
if (rvalue->bit_width == 32) {
|
||||
if (rvalue->signedness == UNSIGNED) {
|
||||
EMIT(c, "((uint32_t) 0x%" PRIx32 ")", (uint32_t) imm->value);
|
||||
} else {
|
||||
EMIT(c, "((int32_t) 0x%" PRIx32 ")", (int32_t) imm->value);
|
||||
}
|
||||
} else if (rvalue->bit_width == 64) {
|
||||
if (rvalue->signedness == UNSIGNED) {
|
||||
EMIT(c, "((uint64_t) 0x%" PRIx64 "ULL)", (uint64_t) imm->value);
|
||||
} else {
|
||||
EMIT(c, "((int64_t) 0x%" PRIx64 "LL)", (int64_t) imm->value);
|
||||
}
|
||||
} else {
|
||||
g_assert_not_reached();
|
||||
}
|
||||
break;
|
||||
case QEMU_TMP:
|
||||
EMIT(c, "qemu_tmp_%" PRIu64, imm->index);
|
||||
|
|
@ -213,7 +228,7 @@ void rvalue_print(Context *c, YYLTYPE *locp, void *pointer)
|
|||
tmp_print(c, locp, &rvalue->tmp);
|
||||
break;
|
||||
case IMMEDIATE:
|
||||
imm_print(c, locp, &rvalue->imm);
|
||||
imm_print(c, locp, rvalue);
|
||||
break;
|
||||
case VARID:
|
||||
var_print(c, locp, &rvalue->var);
|
||||
|
|
@ -386,13 +401,10 @@ HexValue gen_rvalue_extend(Context *c, YYLTYPE *locp, HexValue *rvalue)
|
|||
|
||||
if (rvalue->type == IMMEDIATE) {
|
||||
HexValue res = gen_imm_qemu_tmp(c, locp, 64, rvalue->signedness);
|
||||
bool is_unsigned = (rvalue->signedness == UNSIGNED);
|
||||
const char *sign_suffix = is_unsigned ? "u" : "";
|
||||
gen_c_int_type(c, locp, 64, rvalue->signedness);
|
||||
OUT(c, locp, " ", &res, " = ");
|
||||
OUT(c, locp, "(", sign_suffix, "int64_t) ");
|
||||
OUT(c, locp, "(", sign_suffix, "int32_t) ");
|
||||
OUT(c, locp, rvalue, ";\n");
|
||||
OUT(c, locp, " ", &res, " = (");
|
||||
gen_c_int_type(c, locp, 64, rvalue->signedness);
|
||||
OUT(c, locp, ")", rvalue, ";\n");
|
||||
return res;
|
||||
} else {
|
||||
HexValue res = gen_tmp(c, locp, 64, rvalue->signedness);
|
||||
|
|
@ -959,33 +971,18 @@ HexValue gen_cast_op(Context *c,
|
|||
unsigned target_width,
|
||||
HexSignedness signedness)
|
||||
{
|
||||
HexValue res;
|
||||
assert_signedness(c, locp, src->signedness);
|
||||
if (src->bit_width == target_width) {
|
||||
return *src;
|
||||
} else if (src->type == IMMEDIATE) {
|
||||
HexValue res = *src;
|
||||
res.bit_width = target_width;
|
||||
res.signedness = signedness;
|
||||
return res;
|
||||
res = *src;
|
||||
} else if (src->bit_width < target_width) {
|
||||
res = gen_rvalue_extend(c, locp, src);
|
||||
} else {
|
||||
HexValue res = gen_tmp(c, locp, target_width, signedness);
|
||||
/* Truncate */
|
||||
if (src->bit_width > target_width) {
|
||||
OUT(c, locp, "tcg_gen_trunc_i64_tl(", &res, ", ", src, ");\n");
|
||||
} else {
|
||||
assert_signedness(c, locp, src->signedness);
|
||||
if (src->signedness == UNSIGNED) {
|
||||
/* Extend unsigned */
|
||||
OUT(c, locp, "tcg_gen_extu_i32_i64(",
|
||||
&res, ", ", src, ");\n");
|
||||
} else {
|
||||
/* Extend signed */
|
||||
OUT(c, locp, "tcg_gen_ext_i32_i64(",
|
||||
&res, ", ", src, ");\n");
|
||||
}
|
||||
}
|
||||
return res;
|
||||
/* src->bit_width > target_width */
|
||||
res = gen_rvalue_truncate(c, locp, src);
|
||||
}
|
||||
res.signedness = signedness;
|
||||
return res;
|
||||
}
|
||||
|
||||
|
||||
|
|
|
|||
|
|
@ -80,7 +80,7 @@ void reg_compose(Context *c, YYLTYPE *locp, HexReg *reg, char reg_id[5]);
|
|||
|
||||
void reg_print(Context *c, YYLTYPE *locp, HexReg *reg);
|
||||
|
||||
void imm_print(Context *c, YYLTYPE *locp, HexImm *imm);
|
||||
void imm_print(Context *c, YYLTYPE *locp, HexValue *rvalue);
|
||||
|
||||
void var_print(Context *c, YYLTYPE *locp, HexVar *var);
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue