motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-11 03:24:58 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

qom: strdup() target property name on object_property_add_alias()

Browse source 
With this, object_property_add_alias() callers can safely free the
target property name, like what already happens with the 'name' argument
to all object_property_add*() functions.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
This commit is contained in:
Eduardo Habkost 2015-04-09 16:57:29 -03:00 • committed by Andreas Färber
parent 8ffe756da0
commit 1590d266d9
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
qom/object.c
View file

@ -1705,7 +1705,7 @@ void object_property_add_uint64_ptr(Object *obj, const char *name,
typedef struct { typedef struct {
Object *target_obj; Object *target_obj;
const char *target_name; char *target_name;
} AliasProperty; } AliasProperty;
static void property_get_alias(Object *obj, struct Visitor *v, void *opaque, static void property_get_alias(Object *obj, struct Visitor *v, void *opaque,
@ -1736,6 +1736,7 @@ static void property_release_alias(Object *obj, const char *name, void *opaque)
{ {
AliasProperty *prop = opaque; AliasProperty *prop = opaque;
g_free(prop->target_name);
g_free(prop); g_free(prop);
} }
@ -1763,7 +1764,7 @@ void object_property_add_alias(Object *obj, const char *name,
prop = g_malloc(sizeof(*prop)); prop = g_malloc(sizeof(*prop));
prop->target_obj = target_obj; prop->target_obj = target_obj;
prop->target_name = target_name; prop->target_name = g_strdup(target_name);
op = object_property_add(obj, name, prop_type, op = object_property_add(obj, name, prop_type,
property_get_alias, property_get_alias,