motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-07-30 22:03:54 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

python/machine: use subprocess.run instead of subprocess.Popen

Browse source 
use run() instead of Popen() -- to assert to pylint that we are not
forgetting to close a long-running program.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Tested-by: Cleber Rosa <crosa@redhat.com>
Message-id: 20210527211715.394144-4-jsnow@redhat.com
Message-id: 20210517184808.3562549-4-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
This commit is contained in:
John Snow 2021-05-27 17:16:47 -04:00
parent 07b71233a7
commit 14b41797d5
1 changed files with 9 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

15
python/qemu/machine.py
View file

@ -223,13 +223,16 @@ class QEMUMachine:
assert fd is not None assert fd is not None
fd_param.append(str(fd)) fd_param.append(str(fd))
proc = subprocess.Popen( proc = subprocess.run(
fd_param, stdin=subprocess.DEVNULL, stdout=subprocess.PIPE, fd_param,
stderr=subprocess.STDOUT, close_fds=False stdin=subprocess.DEVNULL,
stdout=subprocess.PIPE,
stderr=subprocess.STDOUT,
check=False,
close_fds=False,
) )
output = proc.communicate()[0] if proc.stdout:
if output: LOG.debug(proc.stdout)
LOG.debug(output)
return proc.returncode return proc.returncode