motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-22 09:32:40 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

hw/usb/hcd-ohci: skip automatic zero-init of large array

Browse source 
The 'ohci_service_iso_td' method has a 8k byte array used for copying
data between guest and host. Skip the automatic zero-init of this
array to eliminate the performance overhead in the I/O hot path.

The 'buf' array will be fully initialized when reading data from guest
memory.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
Reviewed-by: Harsh Prateek Bora <harshpb@linux.ibm.com>
Message-id: 20250610123709.835102-27-berrange@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
This commit is contained in:
Daniel P. Berrangé 2025-06-10 13:37:04 +01:00 • committed by Stefan Hajnoczi
parent 5dd9087fff
commit 14997d521d
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
hw/usb/hcd-ohci.c
View file

@ -577,7 +577,7 @@ static int ohci_service_iso_td(OHCIState *ohci, struct ohci_ed *ed)
USBDevice *dev; USBDevice *dev;
USBEndpoint *ep; USBEndpoint *ep;
USBPacket *pkt; USBPacket *pkt;
uint8_t buf[8192]; QEMU_UNINITIALIZED uint8_t buf[8192];
bool int_req; bool int_req;
struct ohci_iso_td iso_td; struct ohci_iso_td iso_td;
uint32_t addr; uint32_t addr;