contrib/plugins: add a scaling factor to the ips arg

It's easy to get lost in zeros while setting the numbers of
instructions per second. Add a scaling suffix to make things simpler.

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-ID: <20250603110204.838117-6-alex.bennee@linaro.org>
This commit is contained in:
Alex Bennée 2025-06-03 12:01:52 +01:00
parent 26b20dc207
commit 0dd99ef250

View file

@ -129,6 +129,18 @@ static void plugin_exit(qemu_plugin_id_t id, void *udata)
qemu_plugin_scoreboard_free(vcpus);
}
typedef struct {
const char *suffix;
unsigned long multipler;
} ScaleEntry;
/* a bit like units.h but not binary */
static const ScaleEntry scales[] = {
{ "k", 1000 },
{ "m", 1000 * 1000 },
{ "g", 1000 * 1000 * 1000 },
};
QEMU_PLUGIN_EXPORT int qemu_plugin_install(qemu_plugin_id_t id,
const qemu_info_t *info, int argc,
char **argv)
@ -137,12 +149,32 @@ QEMU_PLUGIN_EXPORT int qemu_plugin_install(qemu_plugin_id_t id,
char *opt = argv[i];
g_auto(GStrv) tokens = g_strsplit(opt, "=", 2);
if (g_strcmp0(tokens[0], "ips") == 0) {
max_insn_per_second = g_ascii_strtoull(tokens[1], NULL, 10);
char *endptr = NULL;
max_insn_per_second = g_ascii_strtoull(tokens[1], &endptr, 10);
if (!max_insn_per_second && errno) {
fprintf(stderr, "%s: couldn't parse %s (%s)\n",
__func__, tokens[1], g_strerror(errno));
return -1;
}
if (endptr && *endptr != 0) {
g_autofree gchar *lower = g_utf8_strdown(endptr, -1);
unsigned long scale = 0;
for (int j = 0; j < G_N_ELEMENTS(scales); j++) {
if (g_strcmp0(lower, scales[j].suffix) == 0) {
scale = scales[j].multipler;
break;
}
}
if (scale) {
max_insn_per_second *= scale;
} else {
fprintf(stderr, "bad suffix: %s\n", endptr);
return -1;
}
}
} else {
fprintf(stderr, "option parsing failed: %s\n", opt);
return -1;