motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-07-27 04:13:53 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

qapi: Drop unused error argument for list and implicit struct

Browse source 
No backend was setting an error when ending the visit of a list or
implicit struct, or when moving to the next list node.  Make the
callers a bit easier to follow by making this a part of the contract,
and removing the errp argument - callers can then unconditionally end
an object as part of cleanup without having to think about whether a
second error is dominated by a first, because there is no second
error.

A later patch will then tackle the larger task of splitting
visit_end_struct(), which can indeed set an error.

Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1454075341-13658-24-git-send-email-eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
This commit is contained in:
Eric Blake 2016-01-29 06:48:59 -07:00 • committed by Markus Armbruster
parent bdd8e6b5d8
commit 08f9541dec
11 changed files with 41 additions and 53 deletions
Download patch file Download diff file Expand all files Collapse all files

8
qapi/string-output-visitor.c
View file

@ -1,7 +1,7 @@
/*
* String printing Visitor
*
* Copyright Red Hat, Inc. 2012
* Copyright Red Hat, Inc. 2012-2016
*
* Author: Paolo Bonzini <pbonzini@redhat.com>
*
@ -276,8 +276,7 @@ start_list(Visitor *v, const char *name, Error **errp)
sov->head = true;
}
static GenericList *
next_list(Visitor *v, GenericList **list, Error **errp)
static GenericList *next_list(Visitor *v, GenericList **list)
{
StringOutputVisitor *sov = to_sov(v);
GenericList *ret = NULL;
@ -303,8 +302,7 @@ next_list(Visitor *v, GenericList **list, Error **errp)
return ret;
}
static void
end_list(Visitor *v, Error **errp)
static void end_list(Visitor *v)
{
StringOutputVisitor *sov = to_sov(v);