motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-04 08:13:54 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

target/ppc: Use bool success for ppc_radix64_xlate

Browse source 
Instead of returning non-zero for failure, return true for success.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20210621125115.67717-5-bruno.larsen@eldorado.org.br>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
This commit is contained in:
Richard Henderson 2021-06-21 09:51:09 -03:00 • committed by David Gibson
parent 42a611240e
commit 077a370499
1 changed files with 15 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

30
target/ppc/mmu-radix64.c
View file

@ -463,10 +463,10 @@ static int ppc_radix64_process_scoped_xlate(PowerPCCPU *cpu,
* | = On | Process Scoped | Scoped | * | = On | Process Scoped | Scoped |
* +-------------+----------------+---------------+ * +-------------+----------------+---------------+
*/ */
static int ppc_radix64_xlate(PowerPCCPU *cpu, vaddr eaddr, static bool ppc_radix64_xlate(PowerPCCPU *cpu, vaddr eaddr,
MMUAccessType access_type, MMUAccessType access_type,
hwaddr *raddr, int *psizep, int *protp, hwaddr *raddr, int *psizep, int *protp,
bool guest_visible) bool guest_visible)
{ {
CPUPPCState *env = &cpu->env; CPUPPCState *env = &cpu->env;
uint64_t lpid, pid; uint64_t lpid, pid;
@ -492,7 +492,7 @@ static int ppc_radix64_xlate(PowerPCCPU *cpu, vaddr eaddr,
} }
*protp = PAGE_READ | PAGE_WRITE | PAGE_EXEC; *protp = PAGE_READ | PAGE_WRITE | PAGE_EXEC;
*psizep = TARGET_PAGE_BITS; *psizep = TARGET_PAGE_BITS;
return 0; return true;
} }
/* /*
@ -510,7 +510,7 @@ static int ppc_radix64_xlate(PowerPCCPU *cpu, vaddr eaddr,
if (guest_visible) { if (guest_visible) {
ppc_radix64_raise_segi(cpu, access_type, eaddr); ppc_radix64_raise_segi(cpu, access_type, eaddr);
} }
return 1; return false;
} }
/* Get Process Table */ /* Get Process Table */
@ -523,13 +523,13 @@ static int ppc_radix64_xlate(PowerPCCPU *cpu, vaddr eaddr,
if (guest_visible) { if (guest_visible) {
ppc_radix64_raise_si(cpu, access_type, eaddr, DSISR_NOPTE); ppc_radix64_raise_si(cpu, access_type, eaddr, DSISR_NOPTE);
} }
return 1; return false;
} }
if (!validate_pate(cpu, lpid, &pate)) { if (!validate_pate(cpu, lpid, &pate)) {
if (guest_visible) { if (guest_visible) {
ppc_radix64_raise_si(cpu, access_type, eaddr, DSISR_R_BADCONFIG); ppc_radix64_raise_si(cpu, access_type, eaddr, DSISR_R_BADCONFIG);
} }
return 1; return false;
} }
} }
@ -549,7 +549,7 @@ static int ppc_radix64_xlate(PowerPCCPU *cpu, vaddr eaddr,
pate, &g_raddr, &prot, pate, &g_raddr, &prot,
&psize, guest_visible); &psize, guest_visible);
if (ret) { if (ret) {
return ret; return false;
} }
*psizep = MIN(*psizep, psize); *psizep = MIN(*psizep, psize);
*protp &= prot; *protp &= prot;
@ -573,7 +573,7 @@ static int ppc_radix64_xlate(PowerPCCPU *cpu, vaddr eaddr,
&prot, &psize, false, &prot, &psize, false,
guest_visible); guest_visible);
if (ret) { if (ret) {
return ret; return false;
} }
*psizep = MIN(*psizep, psize); *psizep = MIN(*psizep, psize);
*protp &= prot; *protp &= prot;
@ -582,7 +582,7 @@ static int ppc_radix64_xlate(PowerPCCPU *cpu, vaddr eaddr,
} }
} }
return 0; return true;
} }
int ppc_radix64_handle_mmu_fault(PowerPCCPU *cpu, vaddr eaddr, int ppc_radix64_handle_mmu_fault(PowerPCCPU *cpu, vaddr eaddr,
@ -593,8 +593,8 @@ int ppc_radix64_handle_mmu_fault(PowerPCCPU *cpu, vaddr eaddr,
hwaddr raddr; hwaddr raddr;
/* Translate eaddr to raddr (where raddr is addr qemu needs for access) */ /* Translate eaddr to raddr (where raddr is addr qemu needs for access) */
if (ppc_radix64_xlate(cpu, eaddr, access_type, &raddr, if (!ppc_radix64_xlate(cpu, eaddr, access_type, &raddr,
&page_size, &prot, true)) { &page_size, &prot, true)) {
return 1; return 1;
} }
@ -608,8 +608,8 @@ hwaddr ppc_radix64_get_phys_page_debug(PowerPCCPU *cpu, target_ulong eaddr)
int psize, prot; int psize, prot;
hwaddr raddr; hwaddr raddr;
if (ppc_radix64_xlate(cpu, eaddr, MMU_DATA_LOAD, &raddr, if (!ppc_radix64_xlate(cpu, eaddr, MMU_DATA_LOAD, &raddr,
&psize, &prot, false)) { &psize, &prot, false)) {
return -1; return -1;
} }