motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-04 16:23:55 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

vfio/container: Move realize() after attachment

Browse source 
To match the change for IOMMUFD backend, move realize() after attachment
for legacy backend too.

Suggested-by: Cédric Le Goater <clg@redhat.com>
Suggested-by: Donald Dutile <ddutile@redhat.com>
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Link: https://lore.kernel.org/qemu-devel/20250423072824.3647952-4-zhenzhong.duan@intel.com
Signed-off-by: Cédric Le Goater <clg@redhat.com>
This commit is contained in:
Zhenzhong Duan 2025-04-23 15:28:22 +08:00 • committed by Cédric Le Goater
parent c45d88b8a2
commit 0327ffc853
1 changed files with 12 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

20
hw/vfio/container.c
View file

@ -883,10 +883,6 @@ static bool vfio_legacy_attach_device(const char *name, VFIODevice *vbasedev,
trace_vfio_device_attach(vbasedev->name, groupid);
if (!vfio_device_hiod_realize(vbasedev, errp)) {
return false;
}
group = vfio_group_get(groupid, as, errp);
if (!group) {
return false;
@ -895,13 +891,15 @@ static bool vfio_legacy_attach_device(const char *name, VFIODevice *vbasedev,
QLIST_FOREACH(vbasedev_iter, &group->device_list, next) {
if (strcmp(vbasedev_iter->name, vbasedev->name) == 0) {
error_setg(errp, "device is already attached");
vfio_group_put(group);
return false;
goto group_put_exit;
}
}
if (!vfio_device_get(group, name, vbasedev, errp)) {
vfio_group_put(group);
return false;
goto group_put_exit;
}
if (!vfio_device_hiod_realize(vbasedev, errp)) {
goto device_put_exit;
}
bcontainer = &group->container->bcontainer;
@ -910,6 +908,12 @@ static bool vfio_legacy_attach_device(const char *name, VFIODevice *vbasedev,
QLIST_INSERT_HEAD(&vfio_device_list, vbasedev, global_next);
return true;
device_put_exit:
vfio_device_put(vbasedev);
group_put_exit:
vfio_group_put(group);
return false;
}
static void vfio_legacy_detach_device(VFIODevice *vbasedev)