motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-07-25 19:33:54 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

ui/vnc: Update display update interval when VM state changes to RUNNING

Browse source 
If a virtual machine is paused for an extended period time, for example,
due to an incoming migration, there are also no changes on the screen.
VNC in such case increases the display update interval by
VNC_REFRESH_INTERVAL_INC (50 ms). The update interval can then grow up
to VNC_REFRESH_INTERVAL_MAX (3000 ms).

When the machine resumes, it can then take up to 3 seconds for the first
display update. Furthermore, the update interval is then halved with
each display update with changes on the screen. If there are moving
elements on the screen, such as a video, this can be perceived as
freezing and stuttering for few seconds before the movement is smooth
again.

This patch resolves this issue, by adding a listener to VM state changes
and changing the update interval when the VM state changes to RUNNING.
The update_displaychangelistener() function updates the internal timer,
and the display is refreshed immediately if the timer is expired.

Signed-off-by: Juraj Marcin <jmarcin@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Link: https://lore.kernel.org/r/20250521151616.3951178-1-jmarcin@redhat.com
Signed-off-by: Peter Xu <peterx@redhat.com>
This commit is contained in:
Juraj Marcin 2025-05-21 17:16:13 +02:00 • committed by Peter Xu
parent 8120decfb5
commit 0310d594d9
2 changed files with 14 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
ui/vnc.c
View file

@ -3385,6 +3385,16 @@ static const DisplayChangeListenerOps dcl_ops = {
.dpy_cursor_define = vnc_dpy_cursor_define,
};
static void vmstate_change_handler(void *opaque, bool running, RunState state)
{
VncDisplay *vd = opaque;
if (state != RUN_STATE_RUNNING) {
return;
}
update_displaychangelistener(&vd->dcl, VNC_REFRESH_INTERVAL_BASE);
}
void vnc_display_init(const char *id, Error **errp)
{
VncDisplay *vd;
@ -3421,6 +3431,8 @@ void vnc_display_init(const char *id, Error **errp)
vd->dcl.ops = &dcl_ops;
register_displaychangelistener(&vd->dcl);
vd->kbd = qkbd_state_init(vd->dcl.con);
vd->vmstate_handler_entry = qemu_add_vm_change_state_handler(
&vmstate_change_handler, vd);
}

2
ui/vnc.h
View file

@ -185,6 +185,8 @@ struct VncDisplay
#endif
AudioState *audio_state;
VMChangeStateEntry *vmstate_handler_entry;
};
typedef struct VncTight {