motorhead/qemu
1
0
Fork 0
mirror of https://github.com/Motorhead1991/qemu.git synced 2025-08-04 00:03:54 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions

hw/i386/pc_piix: Wire PIIX3's ISA interrupts by new "isa-irqs" property

Browse source 
Avoid assigning the private member of struct PIIX3State from outside which goes
against best QOM practices. Instead, implement best QOM practice by adding an
"isa-irqs" array property to TYPE_PIIX3_DEVICE and assign it in board code, i.e.
from outside.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Message-Id: <20231007123843.127151-6-shentey@gmail.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
Bernhard Beschow 2023-10-07 14:38:13 +02:00 • committed by Michael S. Tsirkin
parent 32f29b26ff
commit 001cb25f3f
3 changed files with 9 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
include/hw/southbridge/piix.h
View file

@ -46,7 +46,7 @@ struct PIIXState {
#endif
uint64_t pic_levels;
qemu_irq *pic;
qemu_irq pic[ISA_NUM_IRQS];
/* This member isn't used. Just for save/load compatibility */
int32_t pci_irq_levels_vmstate[PIIX_NUM_PIRQS];