vfio/spapr: Extend VFIOIOMMUOps with a release handler

This allows to abstract a bit more the sPAPR IOMMU support in the
legacy IOMMU backend.

Reviewed-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Tested-by: Eric Farman <farman@linux.ibm.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
This commit is contained in:
Cédric Le Goater 2023-12-19 07:58:16 +01:00
parent 0c1eccd368
commit 001a013ea3
3 changed files with 24 additions and 22 deletions

View file

@ -632,9 +632,8 @@ listener_release_exit:
QLIST_REMOVE(bcontainer, next); QLIST_REMOVE(bcontainer, next);
vfio_kvm_device_del_group(group); vfio_kvm_device_del_group(group);
memory_listener_unregister(&bcontainer->listener); memory_listener_unregister(&bcontainer->listener);
if (container->iommu_type == VFIO_SPAPR_TCE_v2_IOMMU || if (bcontainer->ops->release) {
container->iommu_type == VFIO_SPAPR_TCE_IOMMU) { bcontainer->ops->release(bcontainer);
vfio_spapr_container_deinit(container);
} }
enable_discards_exit: enable_discards_exit:
@ -667,9 +666,8 @@ static void vfio_disconnect_container(VFIOGroup *group)
*/ */
if (QLIST_EMPTY(&container->group_list)) { if (QLIST_EMPTY(&container->group_list)) {
memory_listener_unregister(&bcontainer->listener); memory_listener_unregister(&bcontainer->listener);
if (container->iommu_type == VFIO_SPAPR_TCE_v2_IOMMU || if (bcontainer->ops->release) {
container->iommu_type == VFIO_SPAPR_TCE_IOMMU) { bcontainer->ops->release(bcontainer);
vfio_spapr_container_deinit(container);
} }
} }

View file

@ -440,6 +440,24 @@ vfio_spapr_container_del_section_window(VFIOContainerBase *bcontainer,
} }
} }
static void vfio_spapr_container_release(VFIOContainerBase *bcontainer)
{
VFIOContainer *container = container_of(bcontainer, VFIOContainer,
bcontainer);
VFIOSpaprContainer *scontainer = container_of(container, VFIOSpaprContainer,
container);
VFIOHostDMAWindow *hostwin, *next;
if (container->iommu_type == VFIO_SPAPR_TCE_v2_IOMMU) {
memory_listener_unregister(&scontainer->prereg_listener);
}
QLIST_FOREACH_SAFE(hostwin, &scontainer->hostwin_list, hostwin_next,
next) {
QLIST_REMOVE(hostwin, hostwin_next);
g_free(hostwin);
}
}
static VFIOIOMMUOps vfio_iommu_spapr_ops; static VFIOIOMMUOps vfio_iommu_spapr_ops;
static void setup_spapr_ops(VFIOContainerBase *bcontainer) static void setup_spapr_ops(VFIOContainerBase *bcontainer)
@ -447,6 +465,7 @@ static void setup_spapr_ops(VFIOContainerBase *bcontainer)
vfio_iommu_spapr_ops = *bcontainer->ops; vfio_iommu_spapr_ops = *bcontainer->ops;
vfio_iommu_spapr_ops.add_window = vfio_spapr_container_add_section_window; vfio_iommu_spapr_ops.add_window = vfio_spapr_container_add_section_window;
vfio_iommu_spapr_ops.del_window = vfio_spapr_container_del_section_window; vfio_iommu_spapr_ops.del_window = vfio_spapr_container_del_section_window;
vfio_iommu_spapr_ops.release = vfio_spapr_container_release;
bcontainer->ops = &vfio_iommu_spapr_ops; bcontainer->ops = &vfio_iommu_spapr_ops;
} }
@ -527,19 +546,3 @@ listener_unregister_exit:
} }
return ret; return ret;
} }
void vfio_spapr_container_deinit(VFIOContainer *container)
{
VFIOSpaprContainer *scontainer = container_of(container, VFIOSpaprContainer,
container);
VFIOHostDMAWindow *hostwin, *next;
if (container->iommu_type == VFIO_SPAPR_TCE_v2_IOMMU) {
memory_listener_unregister(&scontainer->prereg_listener);
}
QLIST_FOREACH_SAFE(hostwin, &scontainer->hostwin_list, hostwin_next,
next) {
QLIST_REMOVE(hostwin, hostwin_next);
g_free(hostwin);
}
}

View file

@ -117,5 +117,6 @@ struct VFIOIOMMUOps {
Error **errp); Error **errp);
void (*del_window)(VFIOContainerBase *bcontainer, void (*del_window)(VFIOContainerBase *bcontainer,
MemoryRegionSection *section); MemoryRegionSection *section);
void (*release)(VFIOContainerBase *bcontainer);
}; };
#endif /* HW_VFIO_VFIO_CONTAINER_BASE_H */ #endif /* HW_VFIO_VFIO_CONTAINER_BASE_H */