3D-printing/klipper
1
0
Fork 0
mirror of https://github.com/Klipper3d/klipper.git synced 2025-07-23 22:54:10 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

mcu: Do not invert the direction of pullup pins by default

Browse source 
A pullup setting on an input pin (ie, '^') should enable the hardware
pullup resistor, but it should not invert the trigger level (ie, it
should remain trigger on high).  Those that need to change the trigger
level (ie, trigger on low) must now do that explicitly (ie, '^!').
This makes the code match what other firmwares do.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
This commit is contained in:
Kevin O'Connor 2016-11-08 09:29:38 -05:00
parent 3b5b895a10
commit 5e6127869a
3 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
klippy/mcu.py
View file

@ -9,10 +9,10 @@ import serialhdl, pins, chelper
def parse_pin_extras(pin, can_pullup=False):
pullup = invert = 0
if can_pullup and pin.startswith('^'):
pullup = invert = 1
pullup = 1
pin = pin[1:].strip()
if pin.startswith('!'):
invert = invert ^ 1
invert = 1
pin = pin[1:].strip()
return pin, pullup, invert