Remove fix_slicing_errors because it makes no sense (#2370)

this also fixes #2344
This commit is contained in:
Noisyfox 2023-10-12 10:02:27 -05:00 committed by GitHub
parent a178b967dc
commit fc0067ccba
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -656,6 +656,7 @@ void reGroupingLayerPolygons(std::vector<groupedVolumeSlices>& gvss, ExPolygons
} }
} }
/*
std::string fix_slicing_errors(PrintObject* object, LayerPtrs &layers, const std::function<void()> &throw_if_canceled, int &firstLayerReplacedBy) std::string fix_slicing_errors(PrintObject* object, LayerPtrs &layers, const std::function<void()> &throw_if_canceled, int &firstLayerReplacedBy)
{ {
std::string error_msg;//BBS std::string error_msg;//BBS
@ -777,6 +778,7 @@ std::string fix_slicing_errors(PrintObject* object, LayerPtrs &layers, const std
return error_msg; return error_msg;
} }
*/
void groupingVolumesForBrim(PrintObject* object, LayerPtrs& layers, int firstLayerReplacedBy) void groupingVolumesForBrim(PrintObject* object, LayerPtrs& layers, int firstLayerReplacedBy)
{ {
@ -813,7 +815,7 @@ void PrintObject::slice()
m_print->throw_if_canceled(); m_print->throw_if_canceled();
int firstLayerReplacedBy = 0; int firstLayerReplacedBy = 0;
#if 1 #if 0
// Fix the model. // Fix the model.
//FIXME is this the right place to do? It is done repeateadly at the UI and now here at the backend. //FIXME is this the right place to do? It is done repeateadly at the UI and now here at the backend.
std::string warning = fix_slicing_errors(this, m_layers, [this](){ m_print->throw_if_canceled(); }, firstLayerReplacedBy); std::string warning = fix_slicing_errors(this, m_layers, [this](){ m_print->throw_if_canceled(); }, firstLayerReplacedBy);