3D-printing/OrcaSlicer
1
0
Fork 0
mirror of https://github.com/SoftFever/OrcaSlicer.git synced 2025-07-07 06:57:36 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Improve profile check script (#9389)

Browse source 
* Make missing `compatible_printers` error message more clear

* Support checking `compatible_printers` from parent profiles
This commit is contained in:
Noisyfox 2025-04-18 10:48:08 +08:00 • committed by GitHub
parent ee85cda2bb
commit f5849e5c08
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 36 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

40
scripts/orca_extra_profile_check.py
View file

@ -27,6 +27,9 @@ def check_filament_compatible_printers(vendor_folder):
vendor_path = Path(vendor_folder) vendor_path = Path(vendor_folder)
if not vendor_path.exists(): if not vendor_path.exists():
return 0 return 0
profiles = {}
# Use rglob to recursively find .json files. # Use rglob to recursively find .json files.
for file_path in vendor_path.rglob("*.json"): for file_path in vendor_path.rglob("*.json"):
try: try:
@ -42,11 +45,40 @@ def check_filament_compatible_printers(vendor_folder):
error += 1 error += 1
continue continue
instantiation = str(data.get("instantiation", "")).lower() == "true" profile_name = data['name']
compatible_printers = data.get("compatible_printers") if profile_name in profiles:
if instantiation and (not compatible_printers or (isinstance(compatible_printers, list) and not compatible_printers)): print(f"Duplicated profile {profile_name}: {file_path}")
print(file_path)
error += 1 error += 1
continue
profiles[profile_name] = data
def get_inherit_property(data, key):
if key in data:
return data[key]
if 'inherits' in data:
inherits = data['inherits']
if inherits not in profiles:
raise ValueError(f"Parent profile not found: {inherits}")
return get_inherit_property(profiles[inherits], key)
return None
for data in profiles.values():
instantiation = str(data.get("instantiation", "")).lower() == "true"
if instantiation:
try:
compatible_printers = get_inherit_property(data, "compatible_printers")
if not compatible_printers or (isinstance(compatible_printers, list) and not compatible_printers):
print(f"'compatible_printers' missing in {file_path}")
error += 1
except ValueError as ve:
print(f"Unable to parse {file_path}: {ve}")
error += 1
continue
return error return error
def load_available_filament_profiles(profiles_dir, vendor_name): def load_available_filament_profiles(profiles_dir, vendor_name):