From de895e573a0dd60677a78584fbad485206e47fd5 Mon Sep 17 00:00:00 2001 From: "chunmao.guo" Date: Thu, 18 May 2023 17:33:50 +0800 Subject: [PATCH] FIX: [STUDIO-2825] ctrl + tab only switch main pages Change-Id: I10ed43929e4b757fb7c5415ba23a78ded1f2c7d0 (cherry picked from commit 10983c4d177b772e8eda264e5a9957218f779435) --- src/slic3r/GUI/MainFrame.cpp | 4 +++- src/slic3r/GUI/Monitor.cpp | 1 + src/slic3r/GUI/Notebook.hpp | 4 ---- src/slic3r/GUI/Tabbook.hpp | 3 ++- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/slic3r/GUI/MainFrame.cpp b/src/slic3r/GUI/MainFrame.cpp index 4a313a15d3..f164579c26 100644 --- a/src/slic3r/GUI/MainFrame.cpp +++ b/src/slic3r/GUI/MainFrame.cpp @@ -962,7 +962,6 @@ void MainFrame::init_tabpanel() else if (panel == m_monitor) { //monitor } - #ifndef __APPLE__ if (sel == tp3DEditor) { m_topbar->EnableUndoRedoItems(); @@ -972,6 +971,9 @@ void MainFrame::init_tabpanel() } #endif + if (panel) + panel->SetFocus(); + /*switch (sel) { case TabPosition::tpHome: show_option(false); diff --git a/src/slic3r/GUI/Monitor.cpp b/src/slic3r/GUI/Monitor.cpp index c1b53f4b55..a096c9e227 100644 --- a/src/slic3r/GUI/Monitor.cpp +++ b/src/slic3r/GUI/Monitor.cpp @@ -202,6 +202,7 @@ MonitorPanel::~MonitorPanel() auto title = m_tabpanel->GetPageText(m_tabpanel->GetSelection()); m_media_file_panel->SwitchStorage(title == _L("SD Card")); } + page->SetFocus(); }, m_tabpanel->GetId()); //m_status_add_machine_panel = new AddMachinePanel(m_tabpanel); diff --git a/src/slic3r/GUI/Notebook.hpp b/src/slic3r/GUI/Notebook.hpp index 2cd975e9b3..d75898a7cd 100644 --- a/src/slic3r/GUI/Notebook.hpp +++ b/src/slic3r/GUI/Notebook.hpp @@ -30,7 +30,6 @@ public: wxString GetPageText(size_t n) const; private: - wxWindow* m_parent; wxFlexGridSizer* m_buttons_sizer; wxBoxSizer* m_sizer; // BBS: use Button @@ -398,9 +397,6 @@ private: unsigned m_showTimeout, m_hideTimeout; - - ButtonsListCtrl* m_ctrl{ nullptr }; - }; //#endif // _WIN32 #endif // slic3r_Notebook_hpp_ diff --git a/src/slic3r/GUI/Tabbook.hpp b/src/slic3r/GUI/Tabbook.hpp index b57fb907ab..0a32abfe68 100644 --- a/src/slic3r/GUI/Tabbook.hpp +++ b/src/slic3r/GUI/Tabbook.hpp @@ -261,7 +261,8 @@ public: { if (event.IsWindowChange()) { // change pages - AdvanceSelection(event.GetDirection()); + //AdvanceSelection(event.GetDirection()); + this->GetGrandParent()->HandleWindowEvent(event); } else { // we get this event in 3 cases