3D-printing/OrcaSlicer
1
0
Fork 0
mirror of https://github.com/SoftFever/OrcaSlicer.git synced 2025-07-13 09:47:58 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Follow-up of 86d7e1fb90 - Fixed build warning on OsX

Browse source
This commit is contained in:
enricoturri1966 2021-02-18 15:35:38 +01:00
parent 8f293f0cb5
commit d3daea2df8
1 changed files with 16 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

32
src/libslic3r/GCode.cpp
View file

@ -627,15 +627,15 @@ namespace DoExport {
// to be shown in the warning notification // to be shown in the warning notification
// The returned vector is empty if no keyword has been found // The returned vector is empty if no keyword has been found
static std::vector<std::pair<std::string, std::string>> validate_custom_gcode(const Print& print) { static std::vector<std::pair<std::string, std::string>> validate_custom_gcode(const Print& print) {
const unsigned int MAX_COUNT = 5; static const unsigned int MAX_TAGS_COUNT = 5;
std::vector<std::pair<std::string, std::string>> ret; std::vector<std::pair<std::string, std::string>> ret;
auto check = [&ret, MAX_COUNT](const std::string& source, const std::string& gcode) { auto check = [&ret](const std::string& source, const std::string& gcode) {
std::vector<std::string> tags; std::vector<std::string> tags;
if (GCodeProcessor::contains_reserved_tags(gcode, MAX_COUNT, tags)) { if (GCodeProcessor::contains_reserved_tags(gcode, MAX_TAGS_COUNT, tags)) {
if (!tags.empty()) { if (!tags.empty()) {
size_t i = 0; size_t i = 0;
while (ret.size() < MAX_COUNT && i < tags.size()) { while (ret.size() < MAX_TAGS_COUNT && i < tags.size()) {
ret.push_back({ source, tags[i] }); ret.push_back({ source, tags[i] });
++i; ++i;
} }
@ -645,25 +645,25 @@ namespace DoExport {
const GCodeConfig& config = print.config(); const GCodeConfig& config = print.config();
check(_(L("Start G-code")), config.start_gcode.value); check(_(L("Start G-code")), config.start_gcode.value);
if (ret.size() < MAX_COUNT) check(_(L("End G-code")), config.end_gcode.value); if (ret.size() < MAX_TAGS_COUNT) check(_(L("End G-code")), config.end_gcode.value);
if (ret.size() < MAX_COUNT) check(_(L("Before layer change G-code")), config.before_layer_gcode.value); if (ret.size() < MAX_TAGS_COUNT) check(_(L("Before layer change G-code")), config.before_layer_gcode.value);
if (ret.size() < MAX_COUNT) check(_(L("After layer change G-code")), config.layer_gcode.value); if (ret.size() < MAX_TAGS_COUNT) check(_(L("After layer change G-code")), config.layer_gcode.value);
if (ret.size() < MAX_COUNT) check(_(L("Tool change G-code")), config.toolchange_gcode.value); if (ret.size() < MAX_TAGS_COUNT) check(_(L("Tool change G-code")), config.toolchange_gcode.value);
if (ret.size() < MAX_COUNT) check(_(L("Between objects G-code (for sequential printing)")), config.between_objects_gcode.value); if (ret.size() < MAX_TAGS_COUNT) check(_(L("Between objects G-code (for sequential printing)")), config.between_objects_gcode.value);
if (ret.size() < MAX_COUNT) check(_(L("Color Change G-code")), config.color_change_gcode.value); if (ret.size() < MAX_TAGS_COUNT) check(_(L("Color Change G-code")), config.color_change_gcode.value);
if (ret.size() < MAX_COUNT) check(_(L("Pause Print G-code")), config.pause_print_gcode.value); if (ret.size() < MAX_TAGS_COUNT) check(_(L("Pause Print G-code")), config.pause_print_gcode.value);
if (ret.size() < MAX_COUNT) check(_(L("Template Custom G-code")), config.template_custom_gcode.value); if (ret.size() < MAX_TAGS_COUNT) check(_(L("Template Custom G-code")), config.template_custom_gcode.value);
if (ret.size() < MAX_COUNT) { if (ret.size() < MAX_TAGS_COUNT) {
for (const std::string& value : config.start_filament_gcode.values) { for (const std::string& value : config.start_filament_gcode.values) {
check(_(L("Filament Start G-code")), value); check(_(L("Filament Start G-code")), value);
if (ret.size() == MAX_COUNT) if (ret.size() == MAX_TAGS_COUNT)
break; break;
} }
} }
if (ret.size() < MAX_COUNT) { if (ret.size() < MAX_TAGS_COUNT) {
for (const std::string& value : config.end_filament_gcode.values) { for (const std::string& value : config.end_filament_gcode.values) {
check(_(L("Filament End G-code")), value); check(_(L("Filament End G-code")), value);
if (ret.size() == MAX_COUNT) if (ret.size() == MAX_TAGS_COUNT)
break; break;
} }
} }