From b5215dae1be313c8bd2d62f89594e72853ebea82 Mon Sep 17 00:00:00 2001 From: tamasmeszaros Date: Wed, 3 Jul 2019 17:05:08 +0200 Subject: [PATCH] Fix libnest2d tests --- .../libnest2d/placers/bottomleftplacer.hpp | 10 +++++----- .../libnest2d/placers/placer_boilerplate.hpp | 2 -- src/libnest2d/tests/test.cpp | 18 +++++++++++++++--- 3 files changed, 20 insertions(+), 10 deletions(-) diff --git a/src/libnest2d/include/libnest2d/placers/bottomleftplacer.hpp b/src/libnest2d/include/libnest2d/placers/bottomleftplacer.hpp index 28aaad5ce1..e1a4ffbd92 100644 --- a/src/libnest2d/include/libnest2d/placers/bottomleftplacer.hpp +++ b/src/libnest2d/include/libnest2d/placers/bottomleftplacer.hpp @@ -68,11 +68,11 @@ public: return toWallPoly(item, Dir::DOWN); } - inline Unit availableSpaceLeft(const Item& item) { + inline Coord availableSpaceLeft(const Item& item) { return availableSpace(item, Dir::LEFT); } - inline Unit availableSpaceDown(const Item& item) { + inline Coord availableSpaceDown(const Item& item) { return availableSpace(item, Dir::DOWN); } @@ -83,7 +83,7 @@ protected: // Get initial position for item in the top right corner setInitialPosition(item); - Unit d = availableSpaceDown(item); + Coord d = availableSpaceDown(item); auto eps = config_.epsilon; bool can_move = d > eps; bool can_be_packed = can_move; @@ -179,7 +179,7 @@ protected: return ret; } - Unit availableSpace(const Item& _item, const Dir dir) { + Coord availableSpace(const Item& _item, const Dir dir) { Item item (_item.transformedShape()); @@ -223,7 +223,7 @@ protected: cmp); // Get the initial distance in floating point - Unit m = getCoord(*minvertex_it); + Coord m = getCoord(*minvertex_it); // Check available distance for every vertex of item to the objects // in the way for the nearest intersection diff --git a/src/libnest2d/include/libnest2d/placers/placer_boilerplate.hpp b/src/libnest2d/include/libnest2d/placers/placer_boilerplate.hpp index abcd861830..26681aeec6 100644 --- a/src/libnest2d/include/libnest2d/placers/placer_boilerplate.hpp +++ b/src/libnest2d/include/libnest2d/placers/placer_boilerplate.hpp @@ -18,7 +18,6 @@ public: using Segment = _Segment; using BinType = TBin; using Coord = TCoord; - using Unit = Coord; using Config = Cfg; using ItemGroup = _ItemGroup; using DefaultIter = typename ItemGroup::const_iterator; @@ -131,7 +130,6 @@ using typename Base::Vertex; \ using typename Base::Segment; \ using typename Base::PackResult; \ using typename Base::Coord; \ -using typename Base::Unit; \ private: } diff --git a/src/libnest2d/tests/test.cpp b/src/libnest2d/tests/test.cpp index d0c660e498..e5bd871820 100644 --- a/src/libnest2d/tests/test.cpp +++ b/src/libnest2d/tests/test.cpp @@ -363,8 +363,14 @@ TEST(GeometryAlgorithms, ArrangeRectanglesTight) {5, 5}, {20, 20} }; + Box bin(210, 250, {105, 125}); - Nester arrange(Box(210, 250)); + ASSERT_EQ(bin.width(), 210); + ASSERT_EQ(bin.height(), 250); + ASSERT_EQ(getX(bin.center()), 105); + ASSERT_EQ(getY(bin.center()), 125); + + Nester arrange(bin); auto groups = arrange.execute(rects.begin(), rects.end()); @@ -416,10 +422,16 @@ TEST(GeometryAlgorithms, ArrangeRectanglesLoose) {5, 5}, {20, 20} }; + Box bin(210, 250, {105, 125}); + + ASSERT_EQ(bin.width(), 210); + ASSERT_EQ(bin.height(), 250); + ASSERT_EQ(getX(bin.center()), 105); + ASSERT_EQ(getY(bin.center()), 125); + Coord min_obj_distance = 5; - Nester arrange(Box(210, 250), - min_obj_distance); + Nester arrange(bin, min_obj_distance); auto groups = arrange.execute(rects.begin(), rects.end());