3D-printing/OrcaSlicer
1
0
Fork 0
mirror of https://github.com/SoftFever/OrcaSlicer.git synced 2026-01-04 22:07:41 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

FIX: the API return wrong extruder number; remove the assert

Browse source 
jira: [STUDIO-9532]
Change-Id: Ia91a1d277e35f17588de417aee68f418eceb0a11
(cherry picked from commit 2034cadb562d2d4f39a84d0e7c72bc02a23a5f3e)
This commit is contained in:
xin.zhang 2025-01-06 22:02:21 +08:00 • committed by Noisyfox
parent 94ceb3e0a7
commit b09a8ef2a9
3 changed files with 17 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

19
src/slic3r/GUI/PartPlate.cpp
View file

@ -1679,16 +1679,27 @@ std::vector<int> PartPlate::get_extruders_without_support(bool conside_custom_gc
return plate_extruders;
}
/* -1 is invalid, return extruder 0 or 1*/
int PartPlate::get_used_nozzle_by_filament_id(int idx) const
/* -1 is invalid, return physical extruder idx*/
/* logical extruder: 1-left, 2-right*/
/* physical extruder: 0-right, 1-left*/
int PartPlate::get_physical_extruder_by_filament_id(const DynamicConfig& g_config, int idx) const
{
const std::vector<int>& filament_map = get_filament_maps();
const std::vector<int>& filament_map = get_real_filament_maps(g_config);
if (filament_map.size() < idx)
{
return -1;
}
return filament_map[idx - 1] - 1;
int logical_ext_idx = filament_map[idx - 1];
switch (logical_ext_idx)
{
case 1: return 1;
case 2: return 0;
default: break;
}
assert(0);
return -1;
}
std::vector<int> PartPlate::get_used_filaments()

2
src/slic3r/GUI/PartPlate.hpp
View file

@ -327,7 +327,7 @@ public:
std::vector<int> get_extruders_without_support(bool conside_custom_gcode = false) const;
// get used filaments, 1 based idx
std::vector<int> get_used_filaments();
int get_used_nozzle_by_filament_id(int idx) const;
int get_physical_extruder_by_filament_id(const DynamicConfig& g_config, int idx) const;
bool check_tpu_printable_status(const DynamicPrintConfig & config, const std::vector<int> &tpu_filaments);
/* instance related operations*/

2
src/slic3r/GUI/SelectMachine.cpp
View file

@ -1994,7 +1994,7 @@ bool SelectMachineDialog::is_same_nozzle_diameters(float& tag_nozzle_diameter) c
auto used_filament_idxs = cur_plate->get_used_filaments();/*the index is started from 1*/
for (int used_filament_idx : used_filament_idxs)
{
int used_nozzle_idx = cur_plate->get_used_nozzle_by_filament_id(used_filament_idx);
int used_nozzle_idx = cur_plate->get_physical_extruder_by_filament_id(preset_bundle->project_config, used_filament_idx);
if (used_nozzle_idx == -1)
{
assert(0);