Optimization of SLA print time estimation,

moved SLA print time estimation calculation into rasterization step,
so that the print time estimation is tracked by some SLAPrintStep.

Extended the output file name generator to use the SLA print statistics.
This commit is contained in:
bubnikv 2019-02-21 15:46:04 +01:00
parent 37ab271803
commit ac0c7e8065
4 changed files with 100 additions and 96 deletions

View file

@ -14,6 +14,7 @@
namespace Slic3r { namespace Slic3r {
// Used for addressing parameters of FilePrinter::set_statistics()
enum ePrintStatistics enum ePrintStatistics
{ {
psUsedMaterial = 0, psUsedMaterial = 0,

View file

@ -2,6 +2,7 @@
#include "SLA/SLASupportTree.hpp" #include "SLA/SLASupportTree.hpp"
#include "SLA/SLABasePool.hpp" #include "SLA/SLABasePool.hpp"
#include "SLA/SLAAutoSupports.hpp" #include "SLA/SLAAutoSupports.hpp"
#include "ClipperUtils.hpp"
#include "MTUtils.hpp" #include "MTUtils.hpp"
#include <unordered_set> #include <unordered_set>
@ -477,6 +478,15 @@ void SLAPrint::finalize()
m_stepmask[istep] = true; m_stepmask[istep] = true;
} }
// Generate a recommended output file name based on the format template, default extension, and template parameters
// (timestamps, object placeholders derived from the model, current placeholder prameters and print statistics.
// Use the final print statistics if available, or just keep the print statistics placeholders if not available yet (before the output is finalized).
std::string SLAPrint::output_filename() const
{
DynamicConfig config = this->finished() ? this->print_statistics().config() : this->print_statistics().placeholders();
return this->PrintBase::output_filename(m_print_config.output_filename_format.value, "zip", &config);
}
namespace { namespace {
// Compile the argument for support creation from the static print config. // Compile the argument for support creation from the static print config.
sla::SupportConfig make_support_cfg(const SLAPrintObjectConfig& c) { sla::SupportConfig make_support_cfg(const SLAPrintObjectConfig& c) {
@ -960,6 +970,15 @@ void SLAPrint::process()
// Print all the layers in parallel // Print all the layers in parallel
tbb::parallel_for<unsigned, decltype(lvlfn)>(0, lvlcnt, lvlfn); tbb::parallel_for<unsigned, decltype(lvlfn)>(0, lvlcnt, lvlfn);
// Fill statistics
this->fill_statistics();
// Set statistics values to the printer
m_printer->set_statistics({(m_print_statistics.objects_used_material + m_print_statistics.support_used_material)/1000,
10.0,
double(m_print_statistics.slow_layers_count),
double(m_print_statistics.fast_layers_count)
});
}; };
using slaposFn = std::function<void(SLAPrintObject&)>; using slaposFn = std::function<void(SLAPrintObject&)>;
@ -1042,16 +1061,6 @@ void SLAPrint::process()
st += unsigned(PRINT_STEP_LEVELS[currentstep] * pstd); st += unsigned(PRINT_STEP_LEVELS[currentstep] * pstd);
} }
// Fill statistics
fill_statistics();
// Set statistics values to the printer
SLAPrinter& printer = *m_printer;
printer.set_statistics({(m_print_statistics.objects_used_material + m_print_statistics.support_used_material)/1000,
10.0,
double(m_print_statistics.slow_layers_count),
double(m_print_statistics.fast_layers_count)
});
// If everything vent well // If everything vent well
report_status(*this, 100, L("Slicing done")); report_status(*this, 100, L("Slicing done"));
} }
@ -1128,7 +1137,7 @@ void SLAPrint::fill_statistics()
const double init_exp_time = m_material_config.initial_exposure_time.getFloat(); const double init_exp_time = m_material_config.initial_exposure_time.getFloat();
const double exp_time = m_material_config.exposure_time.getFloat(); const double exp_time = m_material_config.exposure_time.getFloat();
const int fade_layers_cnt = m_default_object_config.faded_layers.getInt();// 10 // [3;20] const int fade_layers_cnt = m_default_object_config.faded_layers.getInt();// 10 // [3;20]
const double width = m_printer_config.display_width.getFloat() / SCALING_FACTOR; const double width = m_printer_config.display_width.getFloat() / SCALING_FACTOR;
const double height = m_printer_config.display_height.getFloat() / SCALING_FACTOR; const double height = m_printer_config.display_height.getFloat() / SCALING_FACTOR;
@ -1136,17 +1145,21 @@ void SLAPrint::fill_statistics()
// get polygons for all instances in the object // get polygons for all instances in the object
auto get_all_polygons = [](const ExPolygons& input_polygons, const std::vector<SLAPrintObject::Instance>& instances) { auto get_all_polygons = [](const ExPolygons& input_polygons, const std::vector<SLAPrintObject::Instance>& instances) {
ExPolygons polygons;
const size_t inst_cnt = instances.size(); const size_t inst_cnt = instances.size();
polygons.reserve(input_polygons.size()*inst_cnt); size_t polygon_cnt = 0;
for (const ExPolygon& polygon : input_polygons)
polygon_cnt += polygon.holes.size() + 1;
Polygons polygons;
polygons.reserve(polygon_cnt * inst_cnt);
for (const ExPolygon& polygon : input_polygons) { for (const ExPolygon& polygon : input_polygons) {
for (size_t i = 0; i < inst_cnt; ++i) for (size_t i = 0; i < inst_cnt; ++i)
{ {
ExPolygon tmp = polygon; ExPolygon tmp = polygon;
tmp.rotate(Geometry::rad2deg(instances[i].rotation)); tmp.rotate(Geometry::rad2deg(instances[i].rotation));
tmp.translate(instances[i].shift.x(), instances[i].shift.y()); tmp.translate(instances[i].shift.x(), instances[i].shift.y());
polygons.push_back(tmp); polygons_append(polygons, to_polygons(std::move(tmp)));
} }
} }
return polygons; return polygons;
@ -1161,13 +1174,21 @@ void SLAPrint::fill_statistics()
size_t fast_layers = 0; size_t fast_layers = 0;
// find highest object // find highest object
size_t max_layers_cnt = 0; // Which is a better bet? To compare by max_z or by number of layers in the index?
double max_z = 0.;
size_t max_layers_cnt = 0;
size_t highest_obj_idx = 0; size_t highest_obj_idx = 0;
for (SLAPrintObject * po : m_objects) { for (SLAPrintObject *&po : m_objects) {
const SLAPrintObject::SliceIndex& slice_index = po->get_slice_index(); const SLAPrintObject::SliceIndex& slice_index = po->get_slice_index();
if (max_layers_cnt < slice_index.size()) { if (! slice_index.empty()) {
max_layers_cnt = slice_index.size(); double z = (-- slice_index.end())->first;
highest_obj_idx = std::find(m_objects.begin(), m_objects.end(), po) - m_objects.begin(); size_t cnt = slice_index.size();
//if (z > max_z) {
if (cnt > max_layers_cnt) {
max_layers_cnt = cnt;
max_z = z;
highest_obj_idx = &po - &m_objects.front();
}
} }
} }
@ -1180,9 +1201,7 @@ void SLAPrint::fill_statistics()
int sliced_layer_cnt = 0; int sliced_layer_cnt = 0;
for (const auto& layer : highest_obj_slice_index) for (const auto& layer : highest_obj_slice_index)
{ {
const double l_height = (layer.first == highest_obj_slice_index.begin()->first && const double l_height = (layer.first == highest_obj_slice_index.begin()->first) ? init_layer_height : layer_height;
init_layer_height != layer_height) ?
init_layer_height : layer_height;
// Calculation of the consumed material // Calculation of the consumed material
@ -1191,31 +1210,21 @@ void SLAPrint::fill_statistics()
for (SLAPrintObject * po : m_objects) for (SLAPrintObject * po : m_objects)
{ {
const SLAPrintObject::SliceIndex& index = po->get_slice_index(); const SLAPrintObject::SliceRecord *record = nullptr;
auto key = layer.first; {
if (index.find(layer.first) == index.end()) { const SLAPrintObject::SliceIndex& index = po->get_slice_index();
const SLAPrintObject::SliceIndex::const_iterator it_key = std::find_if(index.begin(), index.end(), auto key = layer.first;
[key](const SLAPrintObject::SliceIndex::value_type& id) -> bool { return std::abs(key - id.first) < EPSILON; }); const SLAPrintObject::SliceIndex::const_iterator it_key = index.lower_bound(key - float(EPSILON));
if (it_key == index.end()) if (it_key == index.end() || it_key->first > key + EPSILON)
continue; continue;
key = it_key->first; record = &it_key->second;
} }
const SLAPrintObject::SliceRecord& record = index.at(key); if (record->model_slices_idx != SLAPrintObject::SliceRecord::NONE)
append(model_polygons, get_all_polygons(po->get_model_slices()[record->model_slices_idx], po->instances()));
if (record.model_slices_idx != SLAPrintObject::SliceRecord::NONE) {
const ExPolygons& expolygons = po->get_model_slices().at(record.model_slices_idx);
const ExPolygons model_expolygons = get_all_polygons(expolygons, po->instances());
append(model_polygons, to_polygons(model_expolygons));
}
if (record.support_slices_idx != SLAPrintObject::SliceRecord::NONE) { if (record->support_slices_idx != SLAPrintObject::SliceRecord::NONE)
const ExPolygons& expolygons = po->get_support_slices().at(record.support_slices_idx); append(supports_polygons, get_all_polygons(po->get_support_slices()[record->support_slices_idx], po->instances()));
const ExPolygons support_expolygons = get_all_polygons(expolygons, po->instances());
append(supports_polygons, to_polygons(support_expolygons));
}
} }
model_polygons = union_(model_polygons); model_polygons = union_(model_polygons);
@ -1227,17 +1236,13 @@ void SLAPrint::fill_statistics()
models_volume += layer_model_area * l_height; models_volume += layer_model_area * l_height;
if (!supports_polygons.empty() && !model_polygons.empty()) if (!supports_polygons.empty() && !model_polygons.empty())
append(supports_polygons, model_polygons); supports_polygons = diff(supports_polygons, model_polygons);
supports_polygons = union_(supports_polygons);
double layer_support_area = 0; double layer_support_area = 0;
for (const Polygon& polygon : supports_polygons) for (const Polygon& polygon : supports_polygons)
layer_support_area += polygon.area(); layer_support_area += polygon.area();
if (layer_support_area != 0) { if (layer_support_area != 0)
layer_support_area -= layer_model_area;
supports_volume += layer_support_area * l_height; supports_volume += layer_support_area * l_height;
}
// Calculation of the slow and fast layers to the future controlling those values on FW // Calculation of the slow and fast layers to the future controlling those values on FW

View file

@ -2,7 +2,6 @@
#define slic3r_SLAPrint_hpp_ #define slic3r_SLAPrint_hpp_
#include <mutex> #include <mutex>
#include "ClipperUtils.hpp"
#include "PrintBase.hpp" #include "PrintBase.hpp"
#include "PrintExport.hpp" #include "PrintExport.hpp"
#include "Point.hpp" #include "Point.hpp"
@ -237,8 +236,7 @@ public:
} }
const PrintObjects& objects() const { return m_objects; } const PrintObjects& objects() const { return m_objects; }
std::string output_filename() const override std::string output_filename() const override;
{ return this->PrintBase::output_filename(m_print_config.output_filename_format.value, "zip"); }
const SLAPrintStatistics& print_statistics() const { return m_print_statistics; } const SLAPrintStatistics& print_statistics() const { return m_print_statistics; }

View file

@ -101,7 +101,7 @@ public:
wxStaticText *label_volume; wxStaticText *label_volume;
wxStaticText *label_materials; wxStaticText *label_materials;
std::vector<wxStaticText *> sla_hided_items; std::vector<wxStaticText *> sla_hidden_items;
bool showing_manifold_warning_icon; bool showing_manifold_warning_icon;
void show_sizer(bool show); void show_sizer(bool show);
@ -145,7 +145,7 @@ ObjectInfo::ObjectInfo(wxWindow *parent) :
sizer_manifold->Add(info_manifold, 0, wxLEFT, 2); sizer_manifold->Add(info_manifold, 0, wxLEFT, 2);
Add(sizer_manifold, 0, wxEXPAND | wxTOP, 4); Add(sizer_manifold, 0, wxEXPAND | wxTOP, 4);
sla_hided_items = { label_volume, info_volume, label_materials, info_materials }; sla_hidden_items = { label_volume, info_volume, label_materials, info_materials };
} }
void ObjectInfo::show_sizer(bool show) void ObjectInfo::show_sizer(bool show)
@ -839,7 +839,7 @@ void Sidebar::show_info_sizer()
p->object_info->show_sizer(true); p->object_info->show_sizer(true);
if (p->plater->printer_technology() == ptSLA) { if (p->plater->printer_technology() == ptSLA) {
for (auto item: p->object_info->sla_hided_items) for (auto item: p->object_info->sla_hidden_items)
item->Show(false); item->Show(false);
} }
} }
@ -876,56 +876,56 @@ void Sidebar::show_sliced_info_sizer(const bool show)
} }
else else
{ {
const PrintStatistics& ps = p->plater->fff_print().print_statistics(); const PrintStatistics& ps = p->plater->fff_print().print_statistics();
const bool is_wipe_tower = ps.total_wipe_tower_filament > 0; const bool is_wipe_tower = ps.total_wipe_tower_filament > 0;
wxString new_label = _(L("Used Filament (m)")); wxString new_label = _(L("Used Filament (m)"));
if (is_wipe_tower) if (is_wipe_tower)
new_label += wxString::Format(" :\n - %s\n - %s", _(L("objects")), _(L("wipe tower"))); new_label += wxString::Format(" :\n - %s\n - %s", _(L("objects")), _(L("wipe tower")));
wxString info_text = is_wipe_tower ? wxString info_text = is_wipe_tower ?
wxString::Format("%.2f \n%.2f \n%.2f", ps.total_used_filament / 1000, wxString::Format("%.2f \n%.2f \n%.2f", ps.total_used_filament / 1000,
(ps.total_used_filament - ps.total_wipe_tower_filament) / 1000, (ps.total_used_filament - ps.total_wipe_tower_filament) / 1000,
ps.total_wipe_tower_filament / 1000) : ps.total_wipe_tower_filament / 1000) :
wxString::Format("%.2f", ps.total_used_filament / 1000); wxString::Format("%.2f", ps.total_used_filament / 1000);
p->sliced_info->SetTextAndShow(siFilament_m, info_text, new_label); p->sliced_info->SetTextAndShow(siFilament_m, info_text, new_label);
p->sliced_info->SetTextAndShow(siFilament_mm3, wxString::Format("%.2f", ps.total_extruded_volume)); p->sliced_info->SetTextAndShow(siFilament_mm3, wxString::Format("%.2f", ps.total_extruded_volume));
p->sliced_info->SetTextAndShow(siFilament_g, wxString::Format("%.2f", ps.total_weight)); p->sliced_info->SetTextAndShow(siFilament_g, wxString::Format("%.2f", ps.total_weight));
new_label = _(L("Cost")); new_label = _(L("Cost"));
if (is_wipe_tower) if (is_wipe_tower)
new_label += wxString::Format(" :\n - %s\n - %s", _(L("objects")), _(L("wipe tower"))); new_label += wxString::Format(" :\n - %s\n - %s", _(L("objects")), _(L("wipe tower")));
info_text = is_wipe_tower ? info_text = is_wipe_tower ?
wxString::Format("%.2f \n%.2f \n%.2f", ps.total_cost, wxString::Format("%.2f \n%.2f \n%.2f", ps.total_cost,
(ps.total_cost - ps.total_wipe_tower_cost), (ps.total_cost - ps.total_wipe_tower_cost),
ps.total_wipe_tower_cost) : ps.total_wipe_tower_cost) :
wxString::Format("%.2f", ps.total_cost); wxString::Format("%.2f", ps.total_cost);
p->sliced_info->SetTextAndShow(siCost, info_text, new_label); p->sliced_info->SetTextAndShow(siCost, info_text, new_label);
if (ps.estimated_normal_print_time == "N/A" && ps.estimated_silent_print_time == "N/A") if (ps.estimated_normal_print_time == "N/A" && ps.estimated_silent_print_time == "N/A")
p->sliced_info->SetTextAndShow(siEstimatedTime, "N/A"); p->sliced_info->SetTextAndShow(siEstimatedTime, "N/A");
else { else {
new_label = _(L("Estimated printing time")) +" :"; new_label = _(L("Estimated printing time")) +" :";
info_text = ""; info_text = "";
if (ps.estimated_normal_print_time != "N/A") { if (ps.estimated_normal_print_time != "N/A") {
new_label += wxString::Format("\n - %s", _(L("normal mode"))); new_label += wxString::Format("\n - %s", _(L("normal mode")));
info_text += wxString::Format("\n%s", ps.estimated_normal_print_time); info_text += wxString::Format("\n%s", ps.estimated_normal_print_time);
}
if (ps.estimated_silent_print_time != "N/A") {
new_label += wxString::Format("\n - %s", _(L("silent mode")));
info_text += wxString::Format("\n%s", ps.estimated_silent_print_time);
}
p->sliced_info->SetTextAndShow(siEstimatedTime, info_text, new_label);
} }
if (ps.estimated_silent_print_time != "N/A") {
new_label += wxString::Format("\n - %s", _(L("silent mode")));
info_text += wxString::Format("\n%s", ps.estimated_silent_print_time);
}
p->sliced_info->SetTextAndShow(siEstimatedTime, info_text, new_label);
}
// if there is a wipe tower, insert number of toolchanges info into the array: // if there is a wipe tower, insert number of toolchanges info into the array:
p->sliced_info->SetTextAndShow(siWTNumbetOfToolchanges, is_wipe_tower ? wxString::Format("%.d", p->plater->fff_print().wipe_tower_data().number_of_toolchanges) : "N/A"); p->sliced_info->SetTextAndShow(siWTNumbetOfToolchanges, is_wipe_tower ? wxString::Format("%.d", p->plater->fff_print().wipe_tower_data().number_of_toolchanges) : "N/A");
// Hide non-FFF sliced info parameters // Hide non-FFF sliced info parameters
p->sliced_info->SetTextAndShow(siMateril_unit, "N/A"); p->sliced_info->SetTextAndShow(siMateril_unit, "N/A");
} }
} }