From a83b005f8ba88a06c4fcc64cec07f7463db545f7 Mon Sep 17 00:00:00 2001 From: Ioannis Giannakas <59056762+igiannakas@users.noreply.github.com> Date: Fri, 9 Jan 2026 15:33:34 +0000 Subject: [PATCH] Bug fix: Display max_junction_deviation warning dialogue only on marlin printers (#11891) # Description max_junction_deviation value is only available for marlin2 printers. Update warning dialogue conditions to only display it for Marlin 2 printers. Fixes #11889 # Screenshots/Recordings/Graphs Before: ![image](https://github.com/user-attachments/assets/62f5bbf0-b726-43b0-9c89-7aaee65e35ce) After: ![image](https://github.com/user-attachments/assets/ec9b83d6-b07d-4885-ba5a-a723387838f5) --- src/libslic3r/Print.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/libslic3r/Print.cpp b/src/libslic3r/Print.cpp index 7a0a6dd867..91236b5144 100644 --- a/src/libslic3r/Print.cpp +++ b/src/libslic3r/Print.cpp @@ -1657,7 +1657,9 @@ StringObjectException Print::validate(StringObjectException *warning, Polygons* // Check junction deviation const auto max_junction_deviation = m_config.machine_max_junction_deviation.values[0]; - if (warning_key.empty() && m_default_object_config.default_junction_deviation.value > max_junction_deviation) { + // Orca: Only marlin FW supports max junction deviation. Dont display warning if firmware is not supporting it. + const bool support_max_junction_deviation = ( m_config.gcode_flavor == gcfMarlinFirmware); + if (warning_key.empty() && m_default_object_config.default_junction_deviation.value > max_junction_deviation && support_max_junction_deviation) { warning->string = L( "Junction deviation setting exceeds the printer's maximum value " "(machine_max_junction_deviation).\nOrca will " "automatically cap the junction deviation to ensure it doesn't surpass the printer's "