3D-printing/OrcaSlicer
1
0
Fork 0
mirror of https://github.com/SoftFever/OrcaSlicer.git synced 2025-10-31 20:51:12 -06:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Fix issue that the slice button is still disabled after a tick is deleted (#2308)

Browse source 
Fix an UAF which causes the slice button being disabled after a tick is deleted
This commit is contained in:
Noisyfox 2023-10-03 11:03:19 -05:00 • committed by GitHub
parent 85e24e62fa
commit 8e70081879
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/slic3r/GUI/IMSlider.cpp
View file

@ -405,8 +405,9 @@ void IMSlider::add_code_as_tick(Type type, int selected_extruder)
}
void IMSlider::delete_tick(const TickCode& tick) {
Type t = tick.type; // Avoid Use-After-Free issue, which resets the tick.type to 0
m_ticks.ticks.erase(tick);
post_ticks_changed_event(tick.type);
post_ticks_changed_event(t);
}
bool IMSlider::check_ticks_changed_event(Type type)