From 83cb9b6f08223f272252933ade38aa7aeb235ed8 Mon Sep 17 00:00:00 2001 From: Raoul Rubien Date: Sun, 14 Sep 2025 23:06:43 +0200 Subject: [PATCH 1/2] fixes: may be used uninitialized [-Wmaybe-uninitialized] --- src/libslic3r/BoundingBox.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libslic3r/BoundingBox.hpp b/src/libslic3r/BoundingBox.hpp index d6baa27012..5e5927b15c 100644 --- a/src/libslic3r/BoundingBox.hpp +++ b/src/libslic3r/BoundingBox.hpp @@ -25,7 +25,7 @@ public: min(p1), max(p1), defined(false) { merge(p2); merge(p3); } template> - BoundingBoxBase(It from, It to) + BoundingBoxBase(It from, It to) : BoundingBoxBase() { construct(*this, from, to); } BoundingBoxBase(const PointsType &points) From 72d87a131aac25fb652eb92fd4a9f7aab25c6c73 Mon Sep 17 00:00:00 2001 From: Raoul Rubien Date: Sun, 14 Sep 2025 23:15:43 +0200 Subject: [PATCH 2/2] fixes: arc_len_next may be used uninitialized [-Wmaybe-uninitialized] --- src/libslic3r/Fill/FillBase.cpp | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/libslic3r/Fill/FillBase.cpp b/src/libslic3r/Fill/FillBase.cpp index 3a9412119f..797d51d7d1 100644 --- a/src/libslic3r/Fill/FillBase.cpp +++ b/src/libslic3r/Fill/FillBase.cpp @@ -1838,18 +1838,18 @@ static inline void base_support_extend_infill_lines(Polylines &infill, BoundaryI const auto dist_min_y = coord_t(line_spacing * 0.5); for (ContourIntersectionPoint &cp : graph.map_infill_end_point_to_boundary) { - const Points &contour = graph.boundary[cp.contour_idx]; - const std::vector &contour_param = graph.boundary_params[cp.contour_idx]; - const Point &pt = contour[cp.point_idx]; - const bool first = graph.first(cp); - int extend_next_idx = -1; - int extend_prev_idx = -1; - coord_t dist_y_prev; - coord_t dist_y_next; - double arc_len_prev; - double arc_len_next; + const Points &contour { graph.boundary[cp.contour_idx] }; + const std::vector &contour_param { graph.boundary_params[cp.contour_idx] }; + const Point &pt { contour[cp.point_idx] }; + const bool first { graph.first(cp) }; + int extend_next_idx { -1 }; + int extend_prev_idx { -1 }; + coord_t dist_y_prev { 0 }; + coord_t dist_y_next { 0 }; + double arc_len_prev { 0 }; + double arc_len_next { 0 }; - if (! graph.next_vertical(cp)){ + if (! graph.next_vertical(cp)) { size_t i = cp.point_idx; size_t j = next_idx_modulo(i, contour); while (j != cp.next_on_contour->point_idx) {