From 897ca1aa449b6c925bcd1853fe95cb3eb81506b5 Mon Sep 17 00:00:00 2001 From: tamasmeszaros Date: Wed, 21 Nov 2018 10:00:49 +0100 Subject: [PATCH] comments... --- src/libslic3r/SLAPrint.cpp | 11 ++++++++++- src/libslic3r/SLAPrint.hpp | 6 ------ 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/src/libslic3r/SLAPrint.cpp b/src/libslic3r/SLAPrint.cpp index 568ff65662..e3b012b7f6 100644 --- a/src/libslic3r/SLAPrint.cpp +++ b/src/libslic3r/SLAPrint.cpp @@ -133,6 +133,15 @@ void SLAPrint::process() double ilhd = m_material_config.initial_layer_height.getFloat(); auto ilh = float(ilhd); + // The slicing will be performed on an imaginary 1D grid which starts from + // the bottom of the bounding box created around the supported model. So + // the first layer which is usually thicker will be part of the supports + // not the model geometry. Exception is when the model is not in the air + // (elevation is zero) and no pad creation was requested. In this case the + // model geometry starts on the ground level and the initial layer is part + // of it. In any case, the model and the supports have to be sliced in the + // same imaginary grid (the height vector argument to TriangleMeshSlicer). + // Slicing the model object. This method is oversimplified and needs to // be compared with the fff slicing algorithm for verification auto slice_model = [this, ilh, ilhd](SLAPrintObject& po) { @@ -152,7 +161,7 @@ void SLAPrint::process() std::vector heights; // The first layer (the one before the initial height) is added only - // if the there is no pad and no elevation value + // if there is no pad and no elevation value if(minZ >= gnd) heights.emplace_back(minZ); for(float h = minZ + ilh; h < maxZ; h += flh) diff --git a/src/libslic3r/SLAPrint.hpp b/src/libslic3r/SLAPrint.hpp index ef30943093..67a1db21a5 100644 --- a/src/libslic3r/SLAPrint.hpp +++ b/src/libslic3r/SLAPrint.hpp @@ -123,12 +123,6 @@ class TriangleMesh; * metadata for the support geometries and their slicing. It should also * dispatch the SLA printing configuration values to the appropriate calculation * steps. - * - * TODO (decide): The last important feature is the support for visualization - * which (at least for now) will be implemented as a method(s) returning the - * triangle meshes or receiving the rendering canvas and drawing on that - * directly. - * */ class SLAPrint : public PrintBaseWithState {