3D-printing/OrcaSlicer
1
0
Fork 0
mirror of https://github.com/SoftFever/OrcaSlicer.git synced 2026-02-16 01:19:47 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Shellcheck everything (#10730)
Some checks failed
Shellcheck / Shellcheck (push) Has been cancelled
Details

Browse source 
* Shellcheck all shell scripts

* Implement Shellcheck's recommendations

* Shellcheck the distribution-specific files

* Include the distro scripts to trigger action

* Fix array usage (hopefully)

* Use single-quote string

TIL: single quote string in yaml treats everything as literal, but
double quote allows backslash escaping.

* Make all cmake commands use set+-x dance and fix macos getopts line

Make Claude happy

getopts has colon after a command which takes an argument

---------

Co-authored-by: SoftFever <softfeverever@gmail.com>
This commit is contained in:
coryrc 2025-09-19 21:12:31 -04:00 • committed by GitHub
parent fa6a73ec5e
commit 7aa3ce8a4d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
11 changed files with 90 additions and 65 deletions
Download patch file Download diff file Expand all files Collapse all files

13
scripts/linux.d/fedora
View file

@ -1,3 +1,5 @@
#!/bin/bash
export FOUND_GTK3
FOUND_GTK3=$(rpm -qa | grep -P '^gtk3' || true)
REQUIRED_DEV_PACKAGES=(
@ -34,16 +36,17 @@ REQUIRED_DEV_PACKAGES=(
if [[ -n "$UPDATE_LIB" ]]
then
NEEDED_PKGS=""
for PKG in ${REQUIRED_DEV_PACKAGES[@]}; do
rpm -q ${PKG} > /dev/null || NEEDED_PKGS+=" ${PKG}"
NEEDED_PKGS=()
for PKG in "${REQUIRED_DEV_PACKAGES[@]}"; do
rpm -q "${PKG}" > /dev/null || NEEDED_PKGS+=("${PKG}")
done
if [ -n "${NEEDED_PKGS}" ]; then
sudo dnf install -y ${NEEDED_PKGS}
if [[ "${#NEEDED_PKGS[*]}" -gt 0 ]]; then
sudo dnf install -y "${NEEDED_PKGS[@]}"
fi
echo -e "done\n"
exit 0
fi
export FOUND_GTK3_DEV
FOUND_GTK3_DEV=$(rpm -qa | grep -P '^gtk3-devel' || true)