Shellcheck everything (#10730)
Some checks failed
Shellcheck / Shellcheck (push) Has been cancelled

* Shellcheck all shell scripts

* Implement Shellcheck's recommendations

* Shellcheck the distribution-specific files

* Include the distro scripts to trigger action

* Fix array usage (hopefully)

* Use single-quote string

TIL: single quote string in yaml treats everything as literal, but
double quote allows backslash escaping.

* Make all cmake commands use set+-x dance and fix macos getopts line

Make Claude happy

getopts has colon after a command which takes an argument

---------

Co-authored-by: SoftFever <softfeverever@gmail.com>
This commit is contained in:
coryrc 2025-09-19 21:12:31 -04:00 committed by GitHub
parent fa6a73ec5e
commit 7aa3ce8a4d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
11 changed files with 90 additions and 65 deletions

View file

@ -13,11 +13,11 @@ docker run \
`# Some X installs will not have permissions to talk to sockets for shared memory` \
--ipc host \
`# Run as your workstations username to keep permissions the same` \
-u $USER \
-u "$USER" \
`# Bind mount your home directory into the container for loading/saving files` \
-v $HOME:/home/$USER \
-v "$HOME:/home/$USER" \
`# Pass the X display number to the container` \
-e DISPLAY=$DISPLAY \
-e DISPLAY="$DISPLAY" \
`# It seems that libGL and dbus things need privileged mode` \
--privileged=true \
`# Attach tty for running orca slicer with command line things` \
@ -25,5 +25,4 @@ docker run \
`# Clean up after yourself` \
--rm \
`# Pass all parameters from this script to the orca slicer ENTRYPOINT binary` \
orcaslicer $*
orcaslicer "$@"